Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract network calls into api delegate #861

Merged
merged 3 commits into from
May 20, 2024
Merged

Extract network calls into api delegate #861

merged 3 commits into from
May 20, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Extracts a few more network calls functions into an api delegate

Testing

Added unit tests

@fractalwrench fractalwrench requested a review from a team as a code owner May 17, 2024 14:18
bidetofevil
bidetofevil approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit b43cf5b into view-tracking-api-delegate May 20, 2024
1 check passed
@fractalwrench fractalwrench deleted the extract-network-calls branch May 20, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidetofevil bidetofevil bidetofevil approved these changes

@fnewberg fnewberg Awaiting requested review from fnewberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fractalwrench @bidetofevil