Add additional metadata to startup traces #839
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bidetofevil and the rest of your teammates on |
| @@ -376,6 +385,14 @@ internal class AppStartupTraceEmitter( | |||
| startupActivityPostCreatedMs?.let { timeMs -> | |||
| addAttribute("startup-activity-post-created-ms", timeMs.toString()) | |||
| } | |||
|
|
|||
| sdkInitEndedInForeground?.let { inForeground -> | |||
| addAttribute("embrace-init-in-foreground", inForeground.toString()) | |||
There was a problem hiding this comment.
Should these be emb instead?
There was a problem hiding this comment.
I actually removed the emb- prefix from the other ones too. The reason for that is because a) this is just a custom attribute on a perf trace logged by us, not an attribute in a fixed schema; b) because it's logged by us, we won't have to worry about disambiguating this with customer data; and c) I'm not convinced that these attributes will be needed in the semantic conventions even if we make app startup spans a thing, so I just want to make them more one-off.
That said, this is mostly in my mind - I should validate this with the entire group first, but lets keep this for now.
bidetofevil
force-pushed
the
hho/add-startup-metadata
branch
from
69a8d13
to
516809c
Compare
bidetofevil
force-pushed
the
hho/add-app-startup-trace-metadata
branch
from
ce96b1f
to
091ea58
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #839 +/- ##
==========================================
+ Coverage 81.05% 81.07% +0.01%
==========================================
Files 427 427
Lines 11442 11453 +11
Branches 1699 1700 +1
==========================================
+ Hits 9274 9285 +11
+ Misses 1458 1457 -1
- Partials 710 711 +1
|
bidetofevil
force-pushed
the
hho/add-app-startup-trace-metadata
branch
from
091ea58
to
91640f2
Compare
Goal
Adding debugging metadata to app startup traces