Use onCreate invocation to denote Activity init start time

[bidetofevil]

Goal

In production, we are seeing a small minority of cases where there is a big gap between when onActivityPreCreated was invoked and when onActivityStart() was invoked. This could be a case of these being two separate activities or instances, or there are cases when the activity creation and starting stage can be paused.

In order to improve the trace and diagnose what's really going on, I changed the trace to use the onCreate time rather than the preCreate time, which is how it works on Android 9 or earlier, as preCreate is not a thing on those API versions. We also explicitly log the pre-create and post-create times as attributes for further debugging if this doesn't end up addressing the problem.

As well as the fix, I tweaked the implementation of the trace logging component (AppStartupTraceEmitter) so it's more streamlined, logs the name of the activity being displayed, removed the emb- prefix on attributes, and extracted the public interface into an interface so i can more easily test the StartupTracker by faking that.

In additional, I added more tests to verify the startup trace being logged properly as well as the StartupTracker consuming lifecycle events properly. I couldn't add test to verify the render due to the limitations of Roboletric, so I've left that alone for now. I've spent way too much time on this already....

Testing

Updated Roboletric to the latest stable version so I can test with U as well as added the modified the appropriate tests.

[bidetofevil]

• Add additional metadata to startup traces #839
• Add metadata to sdk startup trace #838
• Use onCreate invocation to denote Activity init start time #820 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 89.36170% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 81.03%. Comparing base (4ad54a8) to head (b15618f).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #820      +/-   ##
==========================================
+ Coverage   80.99%   81.03%   +0.04%     
==========================================
  Files         426      427       +1     
  Lines       11414    11434      +20     
  Branches     1690     1698       +8     
==========================================
+ Hits         9245     9266      +21     
  Misses       1458     1458              
+ Partials      711      710       -1     

Files	Coverage Δ
...racesdk/capture/startup/AppStartupDataCollector.kt	100.00% <100.00%> (ø)
...d/embracesdk/injection/DataCaptureServiceModule.kt	98.07% <100.00%> (ø)
...droid/embracesdk/capture/startup/StartupTracker.kt	45.71% <94.73%> (+18.59%)	⬆️
...bracesdk/capture/startup/AppStartupTraceEmitter.kt	71.75% <77.77%> (-1.55%)	⬇️

... and 1 file with indirect coverage changes

[fractalwrench]

LGTM