Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark span default as non-private #830

Merged
merged 6 commits into from
May 15, 2024
Merged

Conversation

nelsitoPuglisi
Copy link
Contributor

@nelsitoPuglisi nelsitoPuglisi commented May 9, 2024

Goal

Every span should be exported by default.

Testing

Manual test

Copy link
Contributor Author

nelsitoPuglisi commented May 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nelsitoPuglisi and the rest of your teammates on Graphite Graphite

@nelsitoPuglisi nelsitoPuglisi force-pushed the nelson/fix-public-spans branch 2 times, most recently from 59f17a9 to c381ee1 Compare May 10, 2024 13:15
Base automatically changed from nelson/rn-action-ds to master May 10, 2024 14:58
@nelsitoPuglisi nelsitoPuglisi changed the title mark spans as non-private Mark span default as non-private May 10, 2024
Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nelsitoPuglisi nelsitoPuglisi marked this pull request as ready for review May 14, 2024 17:04
@nelsitoPuglisi nelsitoPuglisi requested a review from a team as a code owner May 14, 2024 17:04
@nelsitoPuglisi nelsitoPuglisi force-pushed the nelson/fix-public-spans branch 2 times, most recently from 3bd824a to bba5e03 Compare May 14, 2024 17:55
@nelsitoPuglisi nelsitoPuglisi merged commit 23c10be into master May 15, 2024
2 checks passed
@nelsitoPuglisi nelsitoPuglisi deleted the nelson/fix-public-spans branch May 15, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants