Mark span default as non-private (#830)

embrace-io · May 15, 2024 · 23c10be · 23c10be
1 parent 30194c1
commit 23c10be
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/...dk/src/integrationTest/kotlin/io/embrace/android/embracesdk/testcases/V2SessionApiTest.kt b/...dk/src/integrationTest/kotlin/io/embrace/android/embracesdk/testcases/V2SessionApiTest.kt
@@ -58,7 +58,6 @@ internal class V2SessionApiTest {
  val networkStatusSpan = snapshots.single { it.name == "emb-network-status" }
  assertEquals(startTime, networkStatusSpan.startTimeNanos.nanosToMillis())
  assertEquals("sys.network_status", networkStatusSpan.attributes["emb.type"])
- assertEquals("true", networkStatusSpan.attributes["emb.private"])
 
  // validate session span
  val sessionSpan = snapshots.single { it.name == "emb-session" }

diff --git a/...roid-sdk/src/main/java/io/embrace/android/embracesdk/capture/crumbs/RnActionDataSource.kt b/...roid-sdk/src/main/java/io/embrace/android/embracesdk/capture/crumbs/RnActionDataSource.kt
@@ -38,7 +38,6 @@ internal open class RnActionDataSource(
  startTimeMs = startTime,
  endTimeMs = endTime,
  type = schemaType.telemetryType,
- private = false,
  attributes = schemaType.attributes()
  )
  }

diff --git a/...ace-android-sdk/src/main/java/io/embrace/android/embracesdk/internal/spans/SpanService.kt b/...ace-android-sdk/src/main/java/io/embrace/android/embracesdk/internal/spans/SpanService.kt
@@ -21,7 +21,7 @@ internal interface SpanService : Initializable {
  parent: EmbraceSpan? = null,
  type: TelemetryType = EmbType.Performance.Default,
  internal: Boolean = true,
- private: Boolean = internal,
+ private: Boolean = false,
  ): PersistableEmbraceSpan?
 
  /**
@@ -33,7 +33,7 @@ internal interface SpanService : Initializable {
  startTimeMs: Long? = null,
  type: TelemetryType = EmbType.Performance.Default,
  internal: Boolean = true,
- private: Boolean = internal
+ private: Boolean = false
  ): PersistableEmbraceSpan? {
  createSpan(
  name = name,

diff --git a/...oid-sdk/src/test/java/io/embrace/android/embracesdk/internal/spans/SpanServiceImplTest.kt b/...oid-sdk/src/test/java/io/embrace/android/embracesdk/internal/spans/SpanServiceImplTest.kt
@@ -68,7 +68,7 @@ internal class SpanServiceImplTest {
  assertEquals(SpanId.getInvalid(), parentSpanId)
  assertIsTypePerformance()
  assertIsKeySpan()
- assertIsPrivateSpan()
+ assertNotPrivateSpan()
  }
  }
 
@@ -140,7 +140,7 @@ internal class SpanServiceImplTest {
  assertEquals(childSpan.spanId, spanId)
  assertEquals(childSpan.traceId, traceId)
  assertNotKeySpan()
- assertIsPrivateSpan()
+ assertNotPrivateSpan()
  }
 
  with(currentSpans[1]) {
@@ -149,7 +149,7 @@ internal class SpanServiceImplTest {
  assertEquals(parentSpan.spanId, spanId)
  assertEquals(parentSpan.traceId, traceId)
  assertIsKeySpan()
- assertIsPrivateSpan()
+ assertNotPrivateSpan()
  }
  }
 
@@ -208,7 +208,7 @@ internal class SpanServiceImplTest {
  assertEquals("emb-child-span", name)
  assertEquals(childStartTimeMs, startTimeNanos.nanosToMillis())
  assertEquals(childSpanEndTimeMs, endTimeNanos.nanosToMillis())
- assertIsPrivateSpan()
+ assertNotPrivateSpan()
  assertNotKeySpan()
  assertIsType(EmbType.Ux.View)
  }