Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate thermal states to OTel #821

Merged
merged 11 commits into from
May 13, 2024
Merged

Migrate thermal states to OTel #821

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
95a0e9e
Added thermal state data source
leandro-godon May 6, 2024
affe785
Renamed ThermalStatusDataSource to ThermalStateDataSource
leandro-godon May 7, 2024
6ec5852
Added test
leandro-godon May 8, 2024
e26d494
Merge branch 'master' into leandro/thermal_states
leandro-godon May 8, 2024
d370521
Remove listener when disabling the data source.
leandro-godon May 8, 2024
f9b73cc
Put the feature behind the beta features flag.
leandro-godon May 8, 2024
e1b9158
Detekt fix.
leandro-godon May 8, 2024
29be5e2
Cosmetic change
leandro-godon May 8, 2024
cd954cc
Merge branch 'master' into leandro/thermal_states
leandro-godon May 9, 2024
c960621
Merge branch 'master' into leandro/thermal_states
leandro-godon May 13, 2024
ad20aaa
Merge branch 'master' into leandro/thermal_states
leandro-godon May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Put the feature behind the beta features flag.
  • Loading branch information
@leandro-godon
leandro-godon committed May 8, 2024
commit f9b73cc2ea387d01fee5783d7eb4bcc5c1e32aba
9 changes: 9 additions & 0 deletions ...sdk/src/integrationTest/kotlin/io/embrace/android/embracesdk/features/ThermalStateTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import io.embrace.android.embracesdk.arch.schema.EmbType
import io.embrace.android.embracesdk.config.remote.DataRemoteConfig
import io.embrace.android.embracesdk.config.remote.RemoteConfig
import io.embrace.android.embracesdk.fakes.fakeAutoDataCaptureBehavior
import io.embrace.android.embracesdk.fakes.fakeSdkModeBehavior
import io.embrace.android.embracesdk.findSpanAttribute
import io.embrace.android.embracesdk.findSpanSnapshotsOfType
import io.embrace.android.embracesdk.findSpansOfType
Expand Down Expand Up @@ -110,5 +111,13 @@ internal class ThermalStateFeatureTest {
)
}
)
testRule.harness.overriddenConfigService.sdkModeBehavior =
fakeSdkModeBehavior(
remoteCfg = {
RemoteConfig(
pctBetaFeaturesEnabled = 100.0f
)
}
)
}
}
5 changes: 4 additions & 1 deletion ...ace-android-sdk/src/main/java/io/embrace/android/embracesdk/injection/DataSourceModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,10 @@ internal class DataSourceModuleImpl(
override val thermalStateDataSource: DataSourceState<ThermalStateDataSource>? by dataSourceState {
DataSourceState(
factory = { thermalService },
configGate = { configService.autoDataCaptureBehavior.isThermalStatusCaptureEnabled() }
configGate = {
configService.autoDataCaptureBehavior.isThermalStatusCaptureEnabled()
&& configService.sdkModeBehavior.isBetaFeaturesEnabled()
}
)
}

Expand Down
Loading