Migrate thermal states to OTel #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #821 +/- ##
==========================================
+ Coverage 81.06% 81.11% +0.05%
==========================================
Files 427 428 +1
Lines 11453 11517 +64
Branches 1700 1710 +10
==========================================
+ Hits 9284 9342 +58
- Misses 1458 1459 +1
- Partials 711 716 +5
|
fractalwrench
approved these changes
May 9, 2024
# Conflicts: # embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/arch/schema/SchemaType.kt # embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/injection/DataSourceModule.kt # embrace-android-sdk/src/test/java/io/embrace/android/embracesdk/injection/DataSourceModuleImplTest.kt
|
I have checked with the backend that neither the older payload nor the new one is being loaded. Backend has now added an explicit rule to drop "perf.thermal_state" spans and snapshots until they are properly loaded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Send thermal state changes as spans.
Removal of the old service will be done in a separate PR.
Testing
The feature is not yet ready on the backend. It was tested against the mock api.