Simple reordering of methods in interface and impls before bigger change

embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/comms/delivery/CacheService.kt

@@ -35,13 +35,6 @@ internal interface CacheService {
      */
     fun cachePayload(name: String, action: SerializationAction)
 
-    /**
-     * Serializes a session object to disk via a stream. This saves memory when the session is large & the return value isn't used
-     * (e.g. for a crash & periodic caching). If an existing session already exists, it will only be replaced if the new [SessionMessage]
-     * is successfully written to disk
-     */
-    fun writeSession(name: String, sessionMessage: SessionMessage)
-
     /**
      * Provides a function that writes the bytes from a cached file, if it exists, to an
      * outputstream
@@ -71,6 +64,13 @@ internal interface CacheService {
      */
     fun loadOldPendingApiCalls(name: String): List<PendingApiCall>?
 
+    /**
+     * Serializes a session object to disk via a stream. This saves memory when the session is large & the return value isn't used
+     * (e.g. for a crash & periodic caching). If an existing session already exists, it will only be replaced if the new [SessionMessage]
+     * is successfully written to disk
+     */
+    fun writeSession(name: String, sessionMessage: SessionMessage)
+
     /**
      * Transform the current saved session with the given name using the given [transformer] and save it in its place
      */

embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/comms/delivery/EmbraceCacheService.kt

@@ -177,6 +177,22 @@ internal class EmbraceCacheService(
         return properSessionFileIds.toList()
     }
 
+    override fun loadOldPendingApiCalls(name: String): List<PendingApiCall>? {
+        findLock(name).read {
+            val file = storageService.getFileForRead(EMBRACE_PREFIX + name)
+            try {
+                val type = Types.newParameterizedType(List::class.java, PendingApiCall::class.java)
+                return serializer.fromJson(file.inputStream(), type) as List<PendingApiCall>?
+                    ?: emptyList()
+            } catch (ex: FileNotFoundException) {
+                logger.logDebug("Cache file cannot be found " + file.path)
+            } catch (ex: Exception) {
+                logger.logDebug("Failed to read cache object " + file.path, ex)
+            }
+            return null
+        }
+    }
+
     override fun writeSession(name: String, sessionMessage: SessionMessage) {
         findLock(name).write {
             var isOverwrite = false
@@ -212,22 +228,6 @@ internal class EmbraceCacheService(
         }
     }
 
-    override fun loadOldPendingApiCalls(name: String): List<PendingApiCall>? {
-        findLock(name).read {
-            val file = storageService.getFileForRead(EMBRACE_PREFIX + name)
-            try {
-                val type = Types.newParameterizedType(List::class.java, PendingApiCall::class.java)
-                return serializer.fromJson(file.inputStream(), type) as List<PendingApiCall>?
-                    ?: emptyList()
-            } catch (ex: FileNotFoundException) {
-                logger.logDebug("Cache file cannot be found " + file.path)
-            } catch (ex: Exception) {
-                logger.logDebug("Failed to read cache object " + file.path, ex)
-            }
-            return null
-        }
-    }
-
     override fun transformSession(name: String, transformer: (SessionMessage) -> SessionMessage) {
         findLock(name).write {
             try {

embrace-android-sdk/src/test/java/io/embrace/android/embracesdk/fakes/FakeCacheService.kt

@@ -14,27 +14,27 @@ internal class FakeCacheService : CacheService {
         TODO("Not yet implemented")
     }
 
-    override fun deleteFile(name: String): Boolean {
+    override fun cachePayload(name: String, action: SerializationAction) {
         TODO("Not yet implemented")
     }
 
-    override fun normalizeCacheAndGetSessionFileIds(): List<String> {
+    override fun loadPayload(name: String): SerializationAction {
         TODO("Not yet implemented")
     }
 
-    override fun writeSession(name: String, sessionMessage: SessionMessage) {
+    override fun deleteFile(name: String): Boolean {
         TODO("Not yet implemented")
     }
 
-    override fun loadOldPendingApiCalls(name: String): List<PendingApiCall>? {
+    override fun normalizeCacheAndGetSessionFileIds(): List<String> {
         TODO("Not yet implemented")
     }
 
-    override fun cachePayload(name: String, action: SerializationAction) {
+    override fun loadOldPendingApiCalls(name: String): List<PendingApiCall>? {
         TODO("Not yet implemented")
     }
 
-    override fun loadPayload(name: String): SerializationAction {
+    override fun writeSession(name: String, sessionMessage: SessionMessage) {
         TODO("Not yet implemented")
     }