Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosted SDK Version Info #578

Merged
merged 51 commits into from
Mar 20, 2024
Merged

Conversation

nelsitoPuglisi
Copy link
Contributor

@nelsitoPuglisi nelsitoPuglisi commented Mar 17, 2024

Goal

This PR creates a class HosteSdkVersionInfo that works as a repository of versions related to hosted SDKs (Unity, Flutter, React Native)
Encapsulates some behavior that was distributed between EmbraceMetadataService and each InternalInterface

The previous behavior was inconsistent, buggy, and hard to read.

To Do:

  • React Native Bundle ID is still in EmbraceMetadataService.
  • PreferencesService has a specific property per hosted sdk. It could be convenient to evaluate if using a new key to simplify the code is worth the effort

Testing

Unit and Integration tests.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 89.36170% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 80.48%. Comparing base (e91d5b4) to head (9f01d17).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #578      +/-   ##
==========================================
- Coverage   80.57%   80.48%   -0.10%     
==========================================
  Files         413      414       +1     
  Lines       11176    11139      -37     
  Branches     1649     1639      -10     
==========================================
- Hits         9005     8965      -40     
- Misses       1514     1515       +1     
- Partials      657      659       +2     
Files Coverage Δ
...ava/io/embrace/android/embracesdk/EmbraceImpl.java 56.06% <ø> (ø)
...android/embracesdk/FlutterInternalInterfaceImpl.kt 91.66% <100.00%> (ø)
...race/android/embracesdk/InternalInterfaceModule.kt 100.00% <100.00%> (ø)
...oid/embracesdk/ReactNativeInternalInterfaceImpl.kt 64.44% <100.00%> (ø)
...e/android/embracesdk/UnityInternalInterfaceImpl.kt 44.44% <100.00%> (-13.79%) ⬇️
...oid/embracesdk/capture/metadata/MetadataService.kt 100.00% <ø> (ø)
...racesdk/capture/metadata/EmbraceMetadataService.kt 87.90% <87.50%> (-1.45%) ⬇️
...oid/embracesdk/injection/EssentialServiceModule.kt 95.74% <85.71%> (+0.15%) ⬆️
...mbracesdk/capture/metadata/HostedSdkVersionInfo.kt 88.23% <88.23%> (ø)

... and 4 files with indirect coverage changes

@nelsitoPuglisi nelsitoPuglisi marked this pull request as ready for review March 20, 2024 14:25
@nelsitoPuglisi nelsitoPuglisi requested a review from a team as a code owner March 20, 2024 14:25
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nelsitoPuglisi nelsitoPuglisi merged commit 49e98b0 into master Mar 20, 2024
4 checks passed
@nelsitoPuglisi nelsitoPuglisi deleted the nelson/hosted-sdk-version-info branch March 20, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants