Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return more data from StartupService #468

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Feb 25, 2024

Goal

Add additional data exposed by the StartupService

@bidetofevil bidetofevil changed the title POC Better app startup trace POC Mar 4, 2024
@bidetofevil bidetofevil marked this pull request as ready for review March 4, 2024 08:25
@bidetofevil bidetofevil requested a review from a team as a code owner March 4, 2024 08:25
Base automatically changed from hho/startup to master March 4, 2024 08:36
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.58%. Comparing base (390f66d) to head (bb36397).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #468      +/-   ##
==========================================
+ Coverage   79.54%   79.58%   +0.03%     
==========================================
  Files         380      381       +1     
  Lines       10300    10304       +4     
  Branches     1509     1510       +1     
==========================================
+ Hits         8193     8200       +7     
+ Misses       1514     1510       -4     
- Partials      593      594       +1     
Files Coverage Δ
...d/embracesdk/capture/startup/StartupServiceImpl.kt 100.00% <100.00%> (ø)
...d/embracesdk/injection/DataCaptureServiceModule.kt 97.95% <100.00%> (+0.08%) ⬆️
...bracesdk/session/message/PayloadMessageCollator.kt 95.50% <100.00%> (ø)

... and 6 files with indirect coverage changes

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator Author

I'll change this to not use the background thread for now and look to change in 6.5 after more testing. I think it'll be an improvement to do on a background thread, but maybe not this one?

@bidetofevil bidetofevil changed the title Better app startup trace POC Return more data from StartupService Mar 5, 2024
Copy link
Collaborator Author

bidetofevil commented Mar 5, 2024

Merge activity

@bidetofevil bidetofevil merged commit f0ef82c into master Mar 5, 2024
6 of 7 checks passed
@bidetofevil bidetofevil deleted the hho/moar-startup branch March 5, 2024 18:17
bidetofevil added a commit that referenced this pull request Mar 5, 2024
## Goal

Add additional data exposed by the StartupService
bidetofevil added a commit that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants