-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return more data from StartupService #468
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bidetofevil and the rest of your teammates on Graphite |
af3c873
to
e451ed9
Compare
embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/EmbraceImpl.java
Outdated
Show resolved
Hide resolved
...ndroid-sdk/src/main/java/io/embrace/android/embracesdk/capture/startup/StartupServiceImpl.kt
Outdated
Show resolved
Hide resolved
a82c9b1
to
40f5b2e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #468 +/- ##
==========================================
+ Coverage 79.54% 79.58% +0.03%
==========================================
Files 380 381 +1
Lines 10300 10304 +4
Branches 1509 1510 +1
==========================================
+ Hits 8193 8200 +7
+ Misses 1514 1510 -4
- Partials 593 594 +1
|
40f5b2e
to
fc16089
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...ndroid-sdk/src/main/java/io/embrace/android/embracesdk/capture/startup/StartupServiceImpl.kt
Outdated
Show resolved
Hide resolved
I'll change this to not use the background thread for now and look to change in 6.5 after more testing. I think it'll be an improvement to do on a background thread, but maybe not this one? |
Merge activity
|
## Goal Add additional data exposed by the StartupService
This reverts commit f9c980e.
Goal
Add additional data exposed by the StartupService