Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tracing sections to startup #467

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Add more tracing sections to startup #467

merged 1 commit into from
Mar 4, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Feb 25, 2024

Goal

Add more tracing sections to startup workflow to better profile SDK startup.

A misleading log line was also removed regarding loading native files

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 91.55844% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 79.45%. Comparing base (02a309f) to head (94c02db).
Report is 1 commits behind head on master.

❗ Current head 94c02db differs from pull request most recent head 949d501. Consider uploading reports for the commit 949d501 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #467      +/-   ##
==========================================
+ Coverage   79.41%   79.45%   +0.03%     
==========================================
  Files         376      373       -3     
  Lines       10204    10122      -82     
  Branches     1497     1474      -23     
==========================================
- Hits         8104     8042      -62     
+ Misses       1510     1500      -10     
+ Partials      590      580      -10     
Files Coverage Δ
...in/java/io/embrace/android/embracesdk/Embrace.java 61.58% <100.00%> (ø)
...ava/io/embrace/android/embracesdk/EmbraceImpl.java 53.03% <100.00%> (ø)
...oid/embracesdk/injection/ModuleInitBootstrapper.kt 94.24% <100.00%> (-0.13%) ⬇️
...d/embracesdk/injection/DataCaptureServiceModule.kt 97.87% <96.29%> (+0.19%) ⬆️
...oid/embracesdk/injection/EssentialServiceModule.kt 95.65% <95.50%> (+0.30%) ⬆️
.../io/embrace/android/embracesdk/ndk/NativeModule.kt 78.04% <75.00%> (+1.73%) ⬆️

... and 18 files with indirect coverage changes

@bidetofevil bidetofevil marked this pull request as ready for review March 2, 2024 08:10
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

)
} else {
NoOpPowerSaveModeService()
Systrace.traceSynchronous("power-service-init") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these just being added as they're the biggest culprits? I was curious why these services are traced but others aren't

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically. I added a bunch of them and most aren't bad. I have another PR that needs more testing that starts to improve on some of these, but I'm not comfortable with getting that in so close to a release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants