[EMBR-631] Make ApiUrlBuilder independent from ConfigService.

[lucaslabari]

Goal

• There were 3 circular dependencies within the EssentialServicesModule:

  • ApiUrlBuilder -> EmbraceMetaDataService -> EmbraceConfigService -> EmbraceApiService -> ApiUrlBuilder
  • ApiUrlBuilder -> EmbraceConfigService -> EmbraceApiService -> ApiUrlBuilder
  • EmbraceConfigService -> EmbraceApiService -> NetworkConnectivityService -> EmbraceConfigService

• The following image shows the interaction between the different components and in red the ones that are part of a circular dependency.

• The dotted lines represent the dependency that is cut in this PR.

• The green dotted lines represent the values that are passed to the constructor of that Class to break the circular dependency.

• In the future, we can separate some of these components to another module so the dependencies are more clearly separated and EssentialServicesModule is not overloaded of services.

Testing

Updated existing unit tests.

[notion-workspace]

Make All Network Requests Through DeliveryNetworkManager

[codecov]

Codecov Report

Merging #10 (6764ab3) into master (a03129f) will increase coverage by 0.15%.
The diff coverage is 89.52%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   73.61%   73.76%   +0.15%     
==========================================
  Files         305      305              
  Lines       10041    10053      +12     
  Branches     1446     1447       +1     
==========================================
+ Hits         7392     7416      +24     
+ Misses       2077     2067      -10     
+ Partials      572      570       -2     

Files	Coverage Δ
...k/capture/aei/EmbraceApplicationExitInfoService.kt	83.68% <100.00%> (+0.72%)	⬆️
...racesdk/capture/metadata/EmbraceMetadataService.kt	84.61% <100.00%> (-0.23%)	⬇️
...droid/embracesdk/comms/api/EmbraceApiUrlBuilder.kt	100.00% <100.00%> (ø)
.../android/embracesdk/config/EmbraceConfigService.kt	85.44% <ø> (-1.44%)	⬇️
...ndroid/embracesdk/injection/DataContainerModule.kt	100.00% <100.00%> (ø)
...mbracesdk/comms/delivery/EmbraceDeliveryService.kt	62.18% <0.00%> (ø)
.../connectivity/EmbraceNetworkConnectivityService.kt	73.40% <77.77%> (-0.79%)	⬇️
.../android/embracesdk/comms/api/EmbraceApiService.kt	47.44% <62.50%> (+1.28%)	⬆️
...oid/embracesdk/injection/EssentialServiceModule.kt	95.38% <91.52%> (-1.32%)	⬇️

... and 4 files with indirect coverage changes

[bidetofevil]

So basically, the crux of the change is to pull out some of the app/device info needed by various services in the EssentialServicesModule and passing them in at init time, rather than having them depend on ConfigService or MetadataService directly to get them?

[bidetofevil]

So I THINK we can make it so that we remove all the circular dependencies for ApiUrlBuilder, and only have appId not be directly consumed from a service. Essentially, the dep graph looks something like

MetadataService -> ConfigService -> ApiService -> ApiUrlBuilder -> PreferenceService

[bidetofevil]

Looks good!