Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EMBR-631] Make ApiUrlBuilder independent from ConfigService. #10

Merged
merged 22 commits into from
Nov 1, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
aaa8fc0
[EMBR-631] Make ApiUrlBuilder independent from ConfigService.
lucaslabari Oct 18, 2023
389abb9
Revert "[EMBR-631] Make ApiUrlBuilder independent from ConfigService."
lucaslabari Oct 27, 2023
e8c06c1
Merge branch 'master' into lucas/EMBR-631
lucaslabari Oct 27, 2023
2c58825
[EMBR-631] Break circular dependencies within EssentialServiceModule.
lucaslabari Oct 27, 2023
25ee1bc
Merge branch 'master' into lucas/EMBR-631
lucaslabari Oct 27, 2023
79225b4
Merge branch 'master' into lucas/EMBR-631
lucaslabari Oct 30, 2023
ae14578
[EMBR-631] Use deviceId from preferenceService in test.
lucaslabari Oct 30, 2023
dd9969b
[EMBR-631] Create FakeApiUrlBuilder
lucaslabari Oct 30, 2023
bf2d0c5
[EMBR-631] Avoid init in FakeCoreModule
lucaslabari Oct 30, 2023
f6875be
[EMBR-631] Rename lazy properties.
lucaslabari Oct 30, 2023
26d1fb3
[EMBR-631] Remove lazy from appId as it's already resolved.
lucaslabari Oct 30, 2023
13973df
[EMBR-631] Remove condition that inits EmbraceNetworkConnectivityServ…
lucaslabari Oct 30, 2023
2a50e6b
Merge branch 'master' into lucas/EMBR-631
lucaslabari Oct 31, 2023
ea6650f
Merge branch 'master' into lucas/EMBR-631
lucaslabari Oct 31, 2023
9e03f8e
[EMBR-631] Fix Unit tests.
lucaslabari Oct 31, 2023
557f2e0
[EMBR-631] Move SdkEndpointBehavior to EssentialServiceModule
lucaslabari Oct 31, 2023
1fe6a7f
[EMBR-631] Move appVersionName and appVersionCode to EssentialService…
lucaslabari Oct 31, 2023
2692a85
[EMBR-631] Remove comma.
lucaslabari Nov 1, 2023
2b7c81a
[EMBR-631] Add comment.
lucaslabari Nov 1, 2023
fb07da8
[EMBR-631] Update logic that handles network status changes.
lucaslabari Nov 1, 2023
7427bfa
[EMBR-631] Update logic that handles network status changes.
lucaslabari Nov 1, 2023
6764ab3
Merge branch 'master' into lucas/EMBR-631
lucaslabari Nov 1, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[EMBR-631] Fix Unit tests.
  • Loading branch information
lucaslabari committed Oct 31, 2023
commit 9e03f8e307172b28edf670836578a508629cae90
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ internal class EmbraceApplicationExitInfoServiceTest {
startApplicationExitInfoService()

// then no null traces should be sent
assertTrue(deliveryService.appExitInfoRequests.isEmpty())
assertTrue(deliveryService.blobMessages.isEmpty())
}

@Test
Expand Down Expand Up @@ -388,7 +388,7 @@ internal class EmbraceApplicationExitInfoServiceTest {
startApplicationExitInfoService()

// then a null trace should be sent
assertTrue(deliveryService.appExitInfoRequests.isEmpty())
assertTrue(deliveryService.blobMessages.isEmpty())
}

@Test
Expand All @@ -405,9 +405,9 @@ internal class EmbraceApplicationExitInfoServiceTest {
startApplicationExitInfoService()

// each AEI object with a trace should be sent in a separate payload
val payloads = checkNotNull(deliveryService.appExitInfoRequests)
val payloads = checkNotNull(deliveryService.blobMessages)
assertEquals(32, payloads.size)
}

private fun getLastAeiRequest() = deliveryService.appExitInfoRequests.single().applicationExits.single()
private fun getLastAeiRequest() = deliveryService.blobMessages.single().applicationExits.single()
}
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ internal class FakeDeliveryService : DeliveryService {
var lastSentCachedSession: String? = null
var lastSavedSession: SessionMessage? = null
val lastSentSessions: MutableList<Pair<SessionMessage, SessionMessageState>> = mutableListOf()
var appExitInfoRequests: MutableList<BlobMessage> = mutableListOf()
var blobMessages: MutableList<BlobMessage> = mutableListOf()

override fun saveSession(sessionMessage: SessionMessage) {
lastSavedSession = sessionMessage
Expand Down Expand Up @@ -85,6 +85,6 @@ internal class FakeDeliveryService : DeliveryService {
}

override fun sendAEIBlob(blobMessage: BlobMessage) {
this.appExitInfoRequests.add(blobMessage)
blobMessages.add(blobMessage)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,10 @@ import com.google.gson.Gson
import io.embrace.android.embracesdk.FakeDeliveryService
import io.embrace.android.embracesdk.ResourceReader
import io.embrace.android.embracesdk.config.local.AppExitInfoLocalConfig
import io.embrace.android.embracesdk.fakes.FakeAndroidMetadataService
import io.embrace.android.embracesdk.fakes.FakeConfigService
import io.embrace.android.embracesdk.fakes.FakePreferenceService
import io.embrace.android.embracesdk.fakes.FakeUserService
import io.embrace.android.embracesdk.fakes.fakeAppExitInfoBehavior
import io.embrace.android.embracesdk.internal.utils.VersionChecker
import io.embrace.android.embracesdk.payload.AppExitInfoData
Expand Down Expand Up @@ -112,7 +114,7 @@ internal class AeiNdkCrashProtobufSendTest {
* Gets the AEI object that was sent to the delivery service
*/
private fun FakeDeliveryService.getAeiObject(): AppExitInfoData {
val requests: List<AppExitInfoData> = appExitInfoRequests.single()
val requests: List<AppExitInfoData> = blobMessages.single().applicationExits
return requests.single()
}

Expand Down Expand Up @@ -149,6 +151,8 @@ internal class AeiNdkCrashProtobufSendTest {
activityManager,
FakePreferenceService(),
deliveryService,
FakeAndroidMetadataService(),
FakeUserService(),