ES|QL: Switch to regex warnings for some CSV tests #110088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigidellaquila
added
>test
elasticsearchmachine
added
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
bpintea
reviewed
Jun 24, 2024
| @@ -165,8 +165,8 @@ notLessThanMultivalue | |||
| required_capability: mv_warn | |||
|
|
|||
| from employees | where not(salary_change < 1) | keep emp_no, salary_change | sort emp_no | limit 5; | |||
| warning:Line 1:24: evaluation of [not(salary_change < 1)] failed, treating result as null. Only first 20 failures recorded.#[Emulated:Line 1:28: evaluation of [salary_change < 1] failed, treating result as null. Only first 20 failures recorded.] | |||
There was a problem hiding this comment.
Wondering if we still need this Emulated functionality. We should maybe add an issue to remove it, if after this PR there's no instances of it left.
There was a problem hiding this comment.
Indeed, with regex we have a way to manage these situations.
As a follow-up I'll double-check and in case I'll remove it. In the meantime I opened this #110092
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some CSV tests randomly fail on environments with multiple nodes (eg. Serverless) because the number of warnings emitted is not completely predictable.
This PR switches to regex warnings, that allow multiple matches for the same warning pattern.