Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES|QL: remove "emulated" option for CSV tests #110092

Closed
luigidellaquila opened this issue Jun 24, 2024 · 1 comment · Fixed by #110124
Closed

ES|QL: remove "emulated" option for CSV tests #110092

luigidellaquila opened this issue Jun 24, 2024 · 1 comment · Fixed by #110124
Assignees
@luigidellaquila
Labels
:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests

Comments

@luigidellaquila
Copy link
Contributor

ES|QL tests can produce slightly different warnings if run as single node vs. CsvTests (mostly different line numbers and more granular expression checks).
To check the two situations separately, we have the following syntax (see the Emulated part):

warning:Line 1:24: java.lang.IllegalArgumentException: single-value function encountered multi-value#[Emulated:Line 1:28: java.lang.IllegalArgumentException: single-value function encountered multi-value]

We have another way to do it, that is use warningRegex, and since we are moving to this option more and more to make the tests more deterministic in multi-node environments (where the number of warnings can be not completely deterministic), we could completely remove the Emulated option and use warningRegex only.
@luigidellaquila luigidellaquila added >test Issues or PRs that are addressing/adding tests :Analytics/ES|QL AKA ESQL labels Jun 24, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 24, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

This was referenced Jun 24, 2024
Merged
Merged
@luigidellaquila luigidellaquila self-assigned this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luigidellaquila luigidellaquila

Labels
:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove 'emulated' option for CSV tests luigidellaquila/elasticsearch
2 participants
@luigidellaquila @elasticsearchmachine