Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not cache SingleValueQuery.LuceneQuery #110082

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

iverase
Copy link
Contributor

@iverase iverase commented Jun 24, 2024

If the query gets cached, then it won't be able to emit warnings for multivalue fields.

fixes #110076

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 24, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@iverase iverase requested a review from nik9000 June 24, 2024 10:04
@iverase iverase merged commit eaffdae into elastic:main Jun 24, 2024
15 checks passed
@iverase iverase added the auto-backport-and-merge Automatically create backport pull requests and merge when ready label Jun 24, 2024
@iverase iverase deleted the SingleValueQuery_cache branch June 24, 2024 13:01
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.14

iverase added a commit to iverase/elasticsearch that referenced this pull request Jun 24, 2024
If the query gets cached, then it won't be able to emit warnings for multivalue fields.
elasticsearchmachine pushed a commit that referenced this pull request Jun 24, 2024
If the query gets cached, then it won't be able to emit warnings for multivalue fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-backport-and-merge Automatically create backport pull requests and merge when ready >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.14.2 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ESQL] SingleValueQuery may stop emitting some warnings if it is cached
3 participants