Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESQL] SingleValueQuery may stop emitting some warnings if it is cached #110076

Closed
iverase opened this issue Jun 23, 2024 · 1 comment · Fixed by #110082
Closed

[ESQL] SingleValueQuery may stop emitting some warnings if it is cached #110076

iverase opened this issue Jun 23, 2024 · 1 comment · Fixed by #110082
Labels
:Analytics/ES|QL AKA ESQL blocker >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@iverase
Copy link
Contributor

iverase commented Jun 23, 2024

SingleValueQuery is a wrapper for lucene queries in ESQL. It wrps queries in order to emit warnings in case queries are being executed against multivalue fields. We don't fail the queries but emit warnings instead.

In #110035 we fixed the implementation of equals and hashcode, with the side effect that queries might be cached by the query cache. The side effect is that queries that emit warnings, when running agains the cached version might stop emitting those warnings which is probably not desire.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL blocker >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants