Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the lineWidth option for line breaking in flow collections #522

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

no92
Copy link
Contributor

@no92 no92 commented Feb 12, 2024

This should address issues #288 and #507.

Copy link
Owner

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising! Should include an additional test or three to exercise the option. Also, see inline comment.

src/stringify/stringifyCollection.ts Outdated Show resolved Hide resolved
@no92
Copy link
Contributor Author

no92 commented Feb 13, 2024

I also amended the commit to include two testcases, with one that wraps and another test that does not.

@eemeli eemeli merged commit 9a8aa0d into eemeli:main Feb 15, 2024
13 checks passed
@no92 no92 deleted the line-breaking-fix branch February 15, 2024 11:41
eemeli added a commit that referenced this pull request Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants