Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/modernisation_inheritance #209

Merged
merged 66 commits into from
May 13, 2024
Merged
Changes from 1 commit
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
a78865c
Prepare migration
joobog Mar 15, 2024
6647a21
Create a todo list
joobog Mar 17, 2024
be71970
Abstract grib_accessor and grib_accessor_class
joobog Mar 17, 2024
35b689a
Accessor backend ready for running accessors
joobog Mar 17, 2024
c598a51
Add "accessor/" prefix to grib_accessor_class_*.cc
joobog Mar 18, 2024
f1d68aa
18% tests passed, 276 tests failed out of 337
joobog Mar 18, 2024
8529fc3
Enable disabled BUFR function calls
joobog Mar 19, 2024
78c1129
Fix offsets
joobog Mar 19, 2024
6fc7074
Fix initialisation
joobog Mar 19, 2024
05e8b45
99% tests passed, 4 tests failed out of 337
joobog Apr 4, 2024
8a7f8c8
Fix compilation
shahramn Apr 4, 2024
1184bcc
Make local functions static
shahramn Apr 4, 2024
77d358a
Fix memory issue
joobog Apr 9, 2024
6bdef3a
Fix compare function
joobog Apr 9, 2024
6f54b96
Merge branch 'feature/modernisation-inheritance' of github.com:ecmwf/…
joobog Apr 9, 2024
ea48de7
PNG fix
joobog Apr 9, 2024
78a9429
Add PNG_ANYBITS
shahramn Apr 9, 2024
8a58ba1
Merge branch 'feature/modernisation-inheritance' of github.com:ecmwf/…
joobog Apr 9, 2024
cec5b2f
Fix destroy() function
joobog Apr 9, 2024
cc40569
Fix memory leak
joobog Apr 9, 2024
eb8bdcf
ECC-1800: GRIB2: Failure setting stepUnits=s,paramId=210203
shahramn Apr 16, 2024
a43c798
C++ modernisation: Added Fortran
shahramn Apr 16, 2024
6f9a1b6
C++ modernisation: Fix Fortran
shahramn Apr 16, 2024
14648c6
Print dataset when concept match fails
shahramn Apr 25, 2024
f229bd5
Remove staticForceStepUnits
shahramn Apr 25, 2024
5dd62ff
Initialise return values
shahramn Apr 25, 2024
17e250b
Cleanup
shahramn Apr 27, 2024
82cb39c
C++: Move function from header to local static
shahramn Apr 27, 2024
aca85e1
C++: Move function from header to local static. Use pragma once
shahramn Apr 27, 2024
6018a0a
Fix the includes: Do not use ..
shahramn Apr 27, 2024
bbcf302
Copyright notices
shahramn Apr 27, 2024
7857878
Remove unnecessary header files
shahramn Apr 27, 2024
f6d4295
Initialize all data members
shahramn Apr 27, 2024
f55015e
Testing: Catch error messages (Setting integer values double array)
shahramn Apr 30, 2024
3630e3b
Merge branch 'develop' into feature/modernisation-inheritance
joobog Apr 30, 2024
437d6c9
Merge branch 'feature/modernisation-inheritance' of github.com:ecmwf/…
joobog May 2, 2024
41a7e62
Merge branch 'develop' into feature/modernisation-inheritance
joobog May 2, 2024
4735c01
Simplify generic pack_double function
joobog May 2, 2024
33dbaa5
Fix reflection
joobog May 2, 2024
ea6fca2
Initialisation of accessors lists
joobog May 3, 2024
7ddc88a
Fix py_bufr_ecc-869.py test
joobog May 7, 2024
5d63a54
Merge branch 'develop' into feature/modernisation-inheritance
joobog May 7, 2024
677f73f
ECC-1820: Fix Windows build
shahramn May 7, 2024
481c78c
ECC-1820: Fix CCSDS class when -DENABLE_AEC=OFF
shahramn May 7, 2024
867da99
Cleanup
joobog May 7, 2024
45b5d55
Merge branch 'feature/modernisation-inheritance' of github.com:ecmwf/…
joobog May 7, 2024
41c513e
ECC-1820: Remove duplicate entry
shahramn May 7, 2024
6b1dae3
Cleanup
joobog May 7, 2024
1a3e11e
Better commment
joobog May 7, 2024
6aa4be2
Remove unnecessary includes
joobog May 7, 2024
ce1aac2
Merge branch 'feature/modernisation-inheritance' of github.com:ecmwf/…
joobog May 7, 2024
57b2698
Compiler warnings re sprintf
shahramn May 8, 2024
cf72dca
Move function from header to local static. Use pragma once
shahramn May 8, 2024
0d802de
Fix grib_accessor_class_gen definition
joobog May 8, 2024
e0f2213
ECC-1820: Remove unnecessary header files
shahramn May 8, 2024
f0b68e4
ECC-1820: Accessor hash
shahramn May 8, 2024
915935d
ECC-1820: Remove unused files
shahramn May 8, 2024
d397f58
ECC-1820: Local static functions
shahramn May 8, 2024
e47f092
Move functions from header to local static. Use 'pragma once'
shahramn May 9, 2024
afb4271
Cosmetics
shahramn May 9, 2024
5661700
ECC-1820: Use 'pragma once' in all header files
shahramn May 10, 2024
98cf979
ECC-1820: grib_accessors_list.rank made private
shahramn May 10, 2024
80d3a68
Cosmetics
shahramn May 10, 2024
ac80478
Cosmetics
shahramn May 10, 2024
22bd62c
Cosmetics
shahramn May 10, 2024
1514b73
Merge branch 'develop' into feature/modernisation-inheritance
shahramn May 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Initialise return values
  • Loading branch information
shahramn committed Apr 25, 2024
commit 5dd62ff5a52dba4fc0ee9f1515469310d9b24240
4 changes: 2 additions & 2 deletions src/accessor/grib_accessor_class_variable.cc
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ void grib_accessor_class_variable_t::init(grib_accessor* a, const long length, g
grib_expression* expression = grib_arguments_get_expression(hand, args, 0);
const char* p = 0;
size_t len = 1;
long l;
long l = 0;
int ret = 0;
double d;
double d = 0;
self->cname = NULL;

a->length = 0;
Expand Down