Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/modernisation_inheritance #209

Merged
merged 66 commits into from
May 13, 2024
Merged

Conversation

shahramn
Copy link
Collaborator

@shahramn shahramn commented May 7, 2024

ECC-1820: Accessor hierarchy in C++

Copy link

github-actions bot commented May 8, 2024

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/8999817782.

Copy link

github-actions bot commented May 8, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/8999945656.

1 similar comment
Copy link

github-actions bot commented May 8, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/8999945656.

Copy link

github-actions bot commented May 8, 2024

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9000429982.

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2024

Codecov Report

Attention: Patch coverage is 92.07547% with 252 lines in your changes are missing coverage. Please review.

Project coverage is 86.31%. Comparing base (7382fb3) to head (5661700).
Report is 2 commits behind head on develop.

❗ Current head 5661700 differs from pull request most recent head 22bd62c. Consider uploading reports for the commit 22bd62c to get more accurate results

Files Patch % Lines
...essor/grib_accessor_class_data_g22order_packing.cc 85.80% 23 Missing ⚠️
..._class_data_g2simple_packing_with_preprocessing.cc 82.35% 15 Missing ⚠️
.../accessor/grib_accessor_class_decimal_precision.cc 76.47% 12 Missing ⚠️
src/accessor/grib_accessor_class_bit.cc 73.17% 11 Missing ⚠️
...essor/grib_accessor_class_data_secondary_bitmap.cc 83.60% 10 Missing ⚠️
src/accessor/grib_accessor_class_bytes.cc 81.63% 9 Missing ⚠️
...c/accessor/grib_accessor_class_data_raw_packing.cc 90.10% 9 Missing ⚠️
...rc/accessor/grib_accessor_class_bufr_data_array.cc 92.38% 8 Missing ⚠️
..._accessor_class_change_alternative_row_scanning.cc 87.09% 8 Missing ⚠️
...ccessor_class_data_apply_boustrophedonic_bitmap.cc 55.55% 8 Missing ⚠️
... and 52 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #209      +/-   ##
===========================================
+ Coverage    86.25%   86.31%   +0.06%     
===========================================
  Files          577      785     +208     
  Lines        62080    62485     +405     
  Branches     11072    10977      -95     
===========================================
+ Hits         53544    53933     +389     
- Misses        8536     8552      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 8, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9004382291.

2 similar comments
Copy link

github-actions bot commented May 8, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9004382291.

Copy link

github-actions bot commented May 8, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9004382291.

Copy link

github-actions bot commented May 9, 2024

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9013785553.

Copy link

github-actions bot commented May 9, 2024

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9017424274.

Copy link

github-actions bot commented May 9, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9017584752.

4 similar comments
Copy link

github-actions bot commented May 9, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9017584752.

Copy link

github-actions bot commented May 9, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9017584752.

Copy link

github-actions bot commented May 9, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9017584752.

Copy link

github-actions bot commented May 9, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9017584752.

Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9031541999.

@shahramn shahramn merged commit 6960978 into develop May 13, 2024
77 of 89 checks passed
@shahramn shahramn deleted the feature/modernisation-inheritance branch May 13, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-for-ci Approved to run CI on ECMWF machines
Projects
None yet
3 participants