Initial Helm Chart implementation #3036
Conversation
Signed-off-by: kamiKAZIK <[email protected]>
| {{ .Values.mosquitto.configFile }} | ||
| {{- if .Values.mosquitto.authentication.passwordFile }} | ||
| password_file {{ required ".Values.mosquitto.authentication.passwordFilePath is required!" .Values.mosquitto.authentication.passwordFilePath | quote }} | ||
| {{- end }} |
There was a problem hiding this comment.
If there is no password file then you should probably add allow_anonymous true since I don't see a way to enable an auth plugin with this chart.
There was a problem hiding this comment.
@hardillb this is actually possible to set-up by adding necessary values using:
{{ .Values.mosquitto.configFile }}
| @@ -0,0 +1,39 @@ | |||
| {{- if and .Values.mosquitto.persistence.enabled -}} | |||
There was a problem hiding this comment.
This file can be added in the statefulSet as volumeClaimtemplate instead
There was a problem hiding this comment.
@jlpedrosa I have made this change. Could you please review it?
| storageClassName: "" | ||
| {{- else }} | ||
| storageClassName: {{ . }} | ||
| {{- end }} |
There was a problem hiding this comment.
could you add here the properties to managed static provisioned volumes? This enables to keep the volumes on the NAS/SAN on cluster reinstall.
{{- if .Values.persistence.existingVolume }}
volumeName: {{ .Values.persistence.existingVolume }}
{{- end }}
{{- if or .Values.persistence.matchLabels (.Values.persistence.matchExpressions) }}
selector:
{{- if .Values.persistence.matchLabels }}
matchLabels:
{{ toYaml .Values.persistence.matchLabels | indent 8 }}
{{- end -}}
{{- if .Values.persistence.matchExpressions }}
matchExpressions:
{{ toYaml .Values.persistence.matchExpressions | indent 8 }}
{{- end -}}
{{- end }}
Here you have a full sample if you want: https://github.com/pajikos/home-assistant-helm-chart/pull/48/files
I still think probably should go to the stateful set, but no big deal.
There was a problem hiding this comment.
I have added this enhancement. It would be great if you could review it
There was a problem hiding this comment.
it LGTM, in any case as soon as the chart goes out, I'll try it out, so I can do some fixes if required,
| {{- end -}} | ||
|
|
||
| {{- define "mosquitto.capabilities.ingress.apiVersion" -}} | ||
| {{- if semverCompare "<1.14-0" (include "mosquitto.capabilities.kubeVersion" .) -}} |
There was a problem hiding this comment.
the last supported version of kube (not EOL) is 1.27, I don't think you need to support 10 year old versions...
There was a problem hiding this comment.
I am more inclined to keep this, as it is already implemented and maybe there are some unlucky guys that are stuck with some very old k8s versions
There was a problem hiding this comment.
Up to you! I feel it keeps complexity for something very, very old that is EOL.
There was a problem hiding this comment.
I indeed would keep the release process in a different PR.
I'd suggest adding a Makefile / similar (and run it in this PR) with https://github.com/norwoodj/helm-docs
.PHONY: helm-docs
helm-docs:
go run github.com/norwoodj/helm-docs/cmd/helm-docs@latest
Side note: I'm not a maintainer at all.
|
@hardillb do you know if we can merge this in? it would be highly appreciated. |
Thank you for contributing your time to the Mosquitto project!
Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.
Then please check the following list of things we ask for in your pull request:
make testwith your changes locally?Greetings, I would like to contribute this Helm Chart for Mosquitto project. I would love if anyone could review it and write down necessary fixed, if there have to be any. It would be nice and useful if the project has it's own officially supported Helm Chart to speed up deployments on Kubernetes.