Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Adding Mosquitto as a separate chart with a dependency #2

Closed
NigelVanHattum opened this issue May 18, 2024 · 5 comments
Closed

Comments

@NigelVanHattum
Copy link

Since Mosquitto is mentioned as the default MQTT broker for Z2M in the getting started docs.

Could we perhaps add a new chart for Mosquitto and add that as a dependency to the main chart? If wanted, I could try to work on this

@jlpedrosa
Copy link
Collaborator

Actually if you go to the mosquitto GH, there's already a PR to create the chart.

@NigelVanHattum
Copy link
Author

Just linking it here, so we can add the dependency once it's merged and released.

Initial Helm Chart implementation #3036

@jlpedrosa
Copy link
Collaborator

Honestly I would not add the dependency here, technically you can use different MQTT implementations not just mosquito. I Would also not pull home assistant into this chart. It also forces to release new versions of this chart when mosquitto is updated. I don't mind adding some examples if it becomes an official chart. But personally I don't think it's a good idea to try to create an stack out of this chart.

@pmarques
Copy link

I share @jlpedrosa's opinion.

@NigelVanHattum
Copy link
Author

Makes sense, I was suggesting it since the docs clearly mention it.

@NigelVanHattum NigelVanHattum closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants