Make ModelConstructionTest, OASFactoryErrorTest activate OpenAPI #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@eclipse-microprofile-bot test this please |
MikeEdgar
approved these changes
Sep 4, 2024
|
I just want to test this against smallrye and OpenLiberty before I merge it. |
|
Thanks for reviewing this! I would primarily need this in the 3.1 stream. There is currently no branch for 3.1, so I can't open a PR. Is there any chance that 3.1.2 release could be made? |
We can probably back-port to 3.1.2. I'll create a branch in history for 3.1.x |
|
Thanks! I created the 3.1.x PR. |
MikeEdgar
approved these changes
Sep 10, 2024
Azquelt
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to resolve #655
After reading #413, I believe these two tests should not be using empty deployment.
OpenAPI should be somehow activated, for the tested functionality to be correctly initialized. The app container have no reason to do this initialization if there is nothing that suggests OpenAPI endpoint is needed.
Currently in Wildfly, these tests only pass if they happen to run after another test from the OpenAPI TCK, where the other test activates OpenAPI for them. They fail if run alone, or if they happen to run as the first test in the module.