Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.1.x] Make ModelConstructionTest, OASFactoryErrorTest activate OpenAPI #659

Merged
merged 1 commit into from
Sep 17, 2024
Merged

[3.1.x] Make ModelConstructionTest, OASFactoryErrorTest activate OpenAPI #659

merged 1 commit into from
Sep 17, 2024

Conversation

TomasHofman
Copy link
Contributor

Upstream PR: #657

Please see discussion on the upstream PR for the rationale.

@TomasHofman TomasHofman changed the base branch from main to 3.1.x September 6, 2024 07:22
@eclipse-microprofile-bot
Copy link
Contributor

Can one of the admins verify this patch?

@MikeEdgar
Copy link
Member

@eclipse-microprofile-bot test this please

MikeEdgar
MikeEdgar approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@MikeEdgar MikeEdgar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does not cause any issues for smallrye-open-api 3.12.x.

Azquelt
Azquelt approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@Azquelt Azquelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't cause any issues on OpenLiberty either.

@MikeEdgar MikeEdgar merged commit 9c1c522 into eclipse:3.1.x Sep 17, 2024
4 checks passed
@MikeEdgar MikeEdgar added this to the MP OpenAPI 3.1.2 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Azquelt Azquelt Azquelt approved these changes

@MikeEdgar MikeEdgar MikeEdgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MP OpenAPI 3.1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@TomasHofman @eclipse-microprofile-bot @MikeEdgar @Azquelt