Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix egbuilder bug, add integration tests for egbuilder #1164

Merged
merged 2 commits into from
Dec 8, 2023
Merged

fix egbuilder bug, add integration tests for egbuilder #1164

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b4577e
fix egbuilder bug, add integration tests for egbuilder
suchen-sci Dec 8, 2023
2aa465d
update integration test
suchen-sci Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update integration test
  • Loading branch information
@suchen-sci
suchen-sci committed Dec 8, 2023
commit 2aa465d08bbe276c44def2f8f03f9e429e00030b
9 changes: 8 additions & 1 deletion build/test/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1167,7 +1167,14 @@ api-addr: 127.0.0.1:22381
runEgCmd.Stderr = &stderrBuf
err = runEgCmd.Start()
assert.Nil(err)
defer runEgCmd.Process.Kill()
defer func() {
err := runEgCmd.Process.Signal(os.Interrupt)
assert.Nil(err)
err = runEgCmd.Wait()
assert.Nil(err)
assert.NotContains(stderrBuf.String(), "panic")
assert.NotContains(stdoutBuf.String(), "panic")
}()

started := checkServerStart(func() *http.Request {
req, err := http.NewRequest(http.MethodGet, apiURL+"/apis/v2/healthz", nil)
Expand Down
Loading