fix egbuilder bug, add integration tests for egbuilder #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1164 +/- ##
==========================================
- Coverage 81.25% 81.05% -0.20%
==========================================
Files 149 149
Lines 16946 16962 +16
==========================================
- Hits 13769 13749 -20
- Misses 2524 2558 +34
- Partials 653 655 +2 ☔ View full report in Codecov by Sentry. |
xxx7xxxx
reviewed
Dec 8, 2023
| return cmd | ||
| } | ||
|
|
||
| func egctlCmd(args ...string) *exec.Cmd { | ||
| return egctlWithServer("http:https://127.0.0.1:12381", args...) |
There was a problem hiding this comment.
Should we use the default option http:https://127.0.0.1:2381 in server.
There was a problem hiding this comment.
good question!
this integration test runs with primary-single instance in example folder. it uses 12381 as its api address...
xxx7xxxx
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue #1163 , the generated code by using
egbuildercontains a bug. This pr fix this bug and also add more integration tests for it.