Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misuse of omitempty in jsonschema #1136

Merged
merged 6 commits into from
Nov 15, 2023
Merged

Fix misuse of omitempty in jsonschema #1136

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a7d582c
Fix misuse of omitempty in jsonschema
xxx7xxxx Nov 13, 2023
9361200
Use active json schema vendor
xxx7xxxx Nov 13, 2023
c7f5142
Fix broken unit tests
xxx7xxxx Nov 13, 2023
7b35fb7
Update pkg/object/nacosserviceregistry/nacosserviceregistry.go
xxx7xxxx Nov 15, 2023
901b78c
Update pkg/object/httpserver/spec.go
xxx7xxxx Nov 15, 2023
ade9ffa
Eliminate more omitempty jsonschema
xxx7xxxx Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update pkg/object/nacosserviceregistry/nacosserviceregistry.go 
Co-authored-by: su chen <[email protected]>
  • Loading branch information
@xxx7xxxx @suchen-sci
xxx7xxxx and suchen-sci committed Nov 15, 2023
commit 7b35fb79b843778bc2d41d5eeafb8f1f2899453f
4 changes: 2 additions & 2 deletions pkg/object/nacosserviceregistry/nacosserviceregistry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,8 @@ type (
ServerSpec struct {
Scheme string `json:"scheme,omitempty" jsonschema:"enum=http,enum=https"`
ContextPath string `json:"contextPath,omitempty"`
IPAddr string `json:"ipAddr,omitempty" jsonschema:"required"`
Port uint16 `json:"port,omitempty" jsonschema:"required"`
IPAddr string `json:"ipAddr" jsonschema:"required"`
Port uint16 `json:"port" jsonschema:"required"`
}

// Status is the status of NacosServiceRegistry.
Expand Down
Loading