Fix misuse of omitempty in jsonschema #1136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix the massive misuse of
omitempty
in #884 . Now the fields without specifyingomitempty
would be required by default.As for the required misuse, I don't think there is a simple and brute solution like
emitempty
. Sincerequired
needs to change the type to its pointer type, which would cause a lot of huge changes. Another way is to change the vendor to do it, which will bring more complexity. I suggest letting it be and changing it in the next development step by step.