add more test in cmd

cmd/client/commandv2/convert/nginx/cmd.go

@@ -45,6 +45,15 @@ func Cmd() *cobra.Command {
  Use: "nginx",
  Short: "Convert nginx.conf to easegress yaml file",
  Args: func(cmd *cobra.Command, args []string) error {
+ if flags.NginxConf == "" {
+ return fmt.Errorf("nginx.conf file path is required")
+ }
+ if flags.Output == "" {
+ return fmt.Errorf("output yaml file path is required")
+ }
+ if flags.Prefix == "" {
+ return fmt.Errorf("prefix is required")
+ }
  return nil
  },
  Run: func(cmd *cobra.Command, args []string) {
@@ -128,5 +137,6 @@ func writeYaml(filename string, servers []*common.HTTPServerSpec, pipelines []*c
  file.WriteString(string(data))
  file.WriteString("\n---\n")
  }
+ file.Sync()
  return nil
 }

cmd/client/commandv2/convert/nginx/cmd_test.go

@@ -18,6 +18,8 @@
 package nginx
 
 import (
+ "io"
+ "os"
  "testing"
 
  "github.com/stretchr/testify/assert"
@@ -26,4 +28,42 @@ import (
 func TestCmd(t *testing.T) {
  cmd := Cmd()
  assert.NotNil(t, cmd)
+ cmd.ParseFlags([]string{""})
+ assert.NotNil(t, cmd.Args(cmd, []string{}))
+
+ cmd.ParseFlags([]string{"-f", "test.conf"})
+ assert.NotNil(t, cmd.Args(cmd, []string{}))
+
+ cmd.ParseFlags([]string{"-o", "test.yaml"})
+ assert.NotNil(t, cmd.Args(cmd, []string{}))
+
+ cmd.ParseFlags([]string{"--prefix", "test"})
+ assert.Nil(t, cmd.Args(cmd, []string{}))
+
+ tempDir := newTempTestDir(t)
+ defer tempDir.Clean()
+
+ nginxConf := `
+ events {}
+ http {
+ server {
+ listen 127.0.0.1:8080;
+
+ location = /user {
+ proxy_pass http:https://localhost:9999;
+ }
+ }
+ }
+ `
+ nginxFile := tempDir.Create("nginx.conf", []byte(nginxConf))
+ outputFile := tempDir.Create("test.yaml", []byte(""))
+ cmd.ParseFlags([]string{"-f", nginxFile, "-o", outputFile, "--prefix", "test"})
+ cmd.Run(cmd, []string{})
+ file, err := os.Open(outputFile)
+ assert.Nil(t, err)
+ defer file.Close()
+ data, err := io.ReadAll(file)
+ assert.Nil(t, err)
+ assert.Contains(t, string(data), "test-8080")
+ assert.Contains(t, string(data), "test-user")
 }

cmd/client/commandv2/create/create_test.go

@@ -27,4 +27,5 @@ import (
 func TestCmd(t *testing.T) {
  cmd := Cmd()
  assert.NotNil(t, cmd)
+ assert.Error(t, cmd.Args(cmd, nil))
 }