Support nginx conf #1130
Merged
Support nginx conf #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
... and 7 files with indirect coverage changes 📢 Thoughts on this report? Let us know! |
xxx7xxxx
reviewed
Nov 9, 2023
cmd/client/commandv2/common/spec.go
Outdated
| @@ -0,0 +1,109 @@ | |||
| /* | |||
There was a problem hiding this comment.
Can we use a more specific package name instead common which is not suggested by any Golang guide.
Ref: https://dave.cheney.net/2019/01/08/avoid-package-names-like-base-util-or-common
There was a problem hiding this comment.
sure, let me update it!
| type Options struct { | ||
| NginxConf string | ||
| Output string | ||
| Prefix string |
There was a problem hiding this comment.
Prefix is too general? Can we use --resource-prefix which is allowed to be empty.
Co-authored-by: Yun Long <[email protected]>
Co-authored-by: Yun Long <[email protected]>
xxx7xxxx
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.