Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cb2-10920): Angular 16 to 17 #1408

Merged
merged 15 commits into from
Feb 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@
"@typescript-eslint/no-unsafe-return": "off",
"@typescript-eslint/ban-types": "off",
"@typescript-eslint/restrict-template-expressions": "off",
"no-void": ["error", { "allowAsStatement": true }]
"no-void": ["error", { "allowAsStatement": true }],
"@typescript-eslint/no-unsafe-enum-comparison": "off"
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
cache: 'npm'

- name: Install dependencies
run: npm ci
run: npm ci --include=optional

- name: Get AWS credentials
uses: aws-actions/configure-aws-credentials@v4
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/pr-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:

strategy:
matrix:
node-version: [18.16.0]
node-version: [18.18.0]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand All @@ -26,7 +26,7 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: 'npm'
- name: Install dependencies
run: npm ci
run: npm ci --include=optional
- name: Build
run: npm run build --ignore-scripts -- --configuration production

Expand All @@ -35,7 +35,7 @@ jobs:

strategy:
matrix:
node-version: [18.16.0]
node-version: [18.18.0]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand All @@ -46,7 +46,7 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: 'npm'
- name: Install dependencies
run: npm ci
run: npm ci --include=optional
- name: Run tests
run: npm run test:workflow

Expand All @@ -55,7 +55,7 @@ jobs:

strategy:
matrix:
node-version: [18.16.0]
node-version: [18.18.0]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand All @@ -66,7 +66,7 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: 'npm'
- name: Install dependencies
run: npm ci
run: npm ci --include=optional
- name: Run linter
run: npm run lint

Expand All @@ -75,7 +75,7 @@ jobs:

strategy:
matrix:
node-version: [18.16.0]
node-version: [18.18.0]
steps:
- uses: actions/checkout@v3
- name: Setup Node.js ${{ matrix.node-version }}
Expand Down Expand Up @@ -105,7 +105,7 @@ jobs:
secret-ids: sonarqube-gha
parse-json-secrets: true
- name: Install dependencies
run: npm ci
run: npm ci --include=optional
- name: Run SonarQube scanner
run: |
npm run sonar-scanner -- \
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ This is used by the DVSA staff to create and update technical records & test res

Prerequisites:

- Node 18
- Node 18.18.0 or higher
- NPM 9.8.1 or higher
- Git Secrets

### Using Make
Expand Down
Loading
Loading