Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cb2-10920): Angular 16 to 17 #1408

Merged
merged 15 commits into from
Feb 27, 2024
Merged

feat(cb2-10920): Angular 16 to 17 #1408

merged 15 commits into from
Feb 27, 2024

Conversation

pbardy2000
Copy link
Contributor

Upgrade angular 15 to 17

CB2-10920

Checklist

  • Branch is rebased against the latest develop/common
  • Code and UI has been tested manually after the additional changes
  • PR title includes the JIRA ticket number
  • Squashed commits contain the JIRA ticket number
  • Delete branch after merge

@github-actions github-actions bot added the enhancement New feature or request label Feb 26, 2024
tomcrawleyy
tomcrawleyy previously approved these changes Feb 26, 2024
matthew2564
matthew2564 previously approved these changes Feb 27, 2024
@naathanbrown
Copy link
Contributor

Happy with this, but I believe the bump to 16 introduced a bug.
image
in the console

Quick look online led me to https://stackoverflow.com/questions/76429842/how-to-find-after-angular-upgrade-16-ng0600-writing-to-signals-is-not-allowed and appears to be a 16 introduction.

I've not really looked any further, but if it's easy reckon we could slip it in with this? Saves us writing a ticket etc. Again if it's hard ignore and go ticket path

@pbardy2000
Copy link
Contributor Author

Happy with this, but I believe the bump to 16 introduced a bug. image in the console

Quick look online led me to https://stackoverflow.com/questions/76429842/how-to-find-after-angular-upgrade-16-ng0600-writing-to-signals-is-not-allowed and appears to be a 16 introduction.

I've not really looked any further, but if it's easy reckon we could slip it in with this? Saves us writing a ticket etc. Again if it's hard ignore and go ticket path

Cheers for that, that page linked to this github issue ngrx/platform#3892 (comment), so I've just applied the fix they suggested which seems to have worked. I think the issue probably arises from the fact that we have a pipe doing a lot of data fetching and interacting with the store which is a bit strange to me but don't want mess around with it too much.

@pbardy2000 pbardy2000 merged commit 78ceeee into develop Feb 27, 2024
10 checks passed
@pbardy2000 pbardy2000 deleted the feat/CB2-10920 branch February 27, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants