Upgrade deps to 2.0 and Generate icons from @phosphor/core #33

mrkpatchaa · 2023-07-31T17:08:59Z

This will help in reducing number of files in this repo + upgrade to the most recent versions of icons.

Generate icons from @phosphor-icons/core -> use latest version a.k.a. 2.x. (Fixes Update to last release v2.0.0 #27 )
Add classname to generated components (Fixes Add a classname to an icon #26)
Upgrade dependencies
Upgrade example app to use latest version of expo (49)

Remove svg files from repo

mrkpatchaa · 2023-08-01T00:07:47Z

@jhhayashi can you check this ?

jacesimons14 · 2023-08-08T04:17:19Z

Would love to see this merged!!!!

mrkpatchaa · 2023-08-08T14:02:40Z

In the meantime I published this npm package https://www.npmjs.com/package/@mrkpatchaa/phosphor-react-native with the latests updates.
I'll take id down once this PR is merged.

jacesimons14 · 2023-08-10T00:49:41Z

sick thanks dude you're a king

jacesimons14 · 2023-08-10T01:06:32Z

@mrkpatchaa I might just be an idiot, does your package require other dependencies? I'm seeing this

mrkpatchaa · 2023-08-10T10:26:52Z

Oh let me check. The typescript types are not pushed to npm.

mrkpatchaa · 2023-08-10T11:22:06Z

@jacesimons14 can you check version 2.0.1? I fixed the types issue.
Old version (this package)

Current version (my package)

I also updated this PR with the fixes.

jacesimons14 · 2023-08-11T00:55:26Z

@mrkpatchaa npm says there hasn't been a new version for 4 days

jacesimons14 · 2023-08-11T00:55:35Z

still 2.0.0

mrkpatchaa · 2023-08-11T09:05:04Z

@jacesimons14 maybe cache? This is the latest version on npm.
You can install the package again or run npm update to get the last version.

jacesimons14 · 2023-08-12T05:39:20Z

Ah I see it now, thank you, works great so far!

daxaxelrod · 2023-08-22T21:23:59Z

Would love this. Have been running into issues where some icons are not available here but they are for the web package so this would be great

jhhayashi · 2023-09-06T19:49:49Z

@jhhayashi can you check this ?

Hey there! I'm not affiliated with this repo, but happy to help where I can.

This PR is a little too large to review. Would it be possible to split it into a few smaller ones?

mrkpatchaa · 2023-09-10T12:49:24Z

@jhhayashi it's only "large" because of the deleted files that are not needed anymore. I am generating icons directly from phospor/core.

You can filter them out in the view.
If you wish I can put them back and make the cleanup afterwards.

This reverts commit 09aa89b.

mrkpatchaa · 2023-09-10T12:54:52Z

@jhhayashi I just pushed a new commit to revert the deletions.
I will create another one for the deletion.

mrkpatchaa · 2023-09-10T12:59:51Z

I just created the companion PR for this. #35

mrkpatchaa · 2023-09-12T21:50:28Z

Would love this. Have been running into issues where some icons are not available here but they are for the web package so this would be great

@daxaxelrod You can use the npm package I published as a temporary solution...
#33 (comment)

jhhayashi

lgtm, but i am not affiliated with the repo

jhhayashi · 2023-09-12T21:53:46Z

generator/generate-svg.js

+
+ const filePath = path.join(
+ svgsDir,
+ `${Case.capital(weight)}/${iconName}.svg`


Suggested change

`${Case.capital(weight)}/${iconName}.svg`

`${Case.pascal(weight)}/${iconName}.svg`

might as well guarantee that there aren't spaces

We have control over the folder structure. In cases there are spaces We'd need to change more logic I think. Not only this line.

jhhayashi · 2023-09-12T22:03:04Z

generator/generate-svg.js

 componentName: componentNameMap[componentName] || componentName,
 }).then((tsCode) => {
 tsCode = tsCode
 .replace('SvgProps, ', '')
- .replace('function', "import { IconProps } from '../lib'\n\nfunction")
+ .replace('const', "import { IconProps } from '../lib'\n\nconst")


maybe better to just insert the import at the beginning of the string instead of hardcoding the first non-import line prefix?

Making the replace helps keep the import after React import.

jhhayashi · 2023-09-12T22:04:25Z

generator/generate-svg.js

- const srcDir = path.join(__dirname, '../src');
-
- svgr(svgCode, options, {
+ transform(svgCode, options, {
 componentName: componentNameMap[componentName] || componentName,
 }).then((tsCode) => {
 tsCode = tsCode
 .replace('SvgProps, ', '')


this line can be removed (superseded by the .replace(/import type .*;\n/g, '') line)

jhhayashi · 2023-09-12T22:10:00Z

generator/generate-svg.js

+ fs.rmSync(srcDir + '/' + folders[index], {
+ recursive: true,
+ force: true,
+ });


looks like https://github.com/jprichardson/node-fs-extra/blob/HEAD/docs/remove-sync.md can save you a few lines

mrkpatchaa · 2023-09-13T10:26:22Z

@duongdev @Joeao @kingdavidmartins @bkdev98 are you guys able to check this and merge?
I created another npm package as a temporary solution but might be interesting to update this repo.

DavidP-B · 2023-10-04T14:39:18Z

In the meantime I published this npm package https://www.npmjs.com/package/@mrkpatchaa/phosphor-react-native with the latests updates. I'll take id down once this PR is merged.

I'm using your library meanwhile this PR is accepted. I've founded that you maybe forgot to import FileSearch icon... I'm using this icon but when I change to your library I can't see it.

mrkpatchaa · 2023-10-04T20:31:26Z

@DavidP-B I just checked and file-search is an alias for file-magnifying-glass -> https://github.com/phosphor-icons/core/blob/main/bin/index.js
Maybe it would be interresting to add this as well in this PR. I'll try to find some time to do it this week.
Anyway, seems like the repo is not maintained anymore. I couldn't get anyone to merge this 😕

duongdev · 2023-10-05T15:25:51Z

Thank you @mrkpatchaa @DavidP-B and @jacesimons14 for your contribution. I am not currently work with React Native but your efforts on this library is so incredible!

mrkpatchaa · 2023-10-05T15:57:43Z

Thank you @mrkpatchaa @DavidP-B and @jacesimons14 for your contribution. I am not currently work with React Native but your efforts on this library is so incredible!

Hi @duongdev and happy to finally hear from you 😄
What are the plans to continue maintaining the project? I can help if you want.
In the meantime, with the new approach, it will require less work to maintain.
Think also about the option of moving it to @Phospor community?

jhhayashi · 2023-10-05T16:03:28Z

Hey @mrkpatchaa!

@duongdev got me set up on this repo (see #34), so I'll now be able to help out with the maintenance. I have an active project that depends on this library, so I'll make sure to keep things maintained

mrkpatchaa · 2023-10-05T16:05:04Z

Understood @jhhayashi . I also have an active project using it.
Feel free to let me know if you need help on something.
Good luck mate.

jhhayashi · 2023-10-15T23:05:09Z

Thanks for the patience; v2.0.0 has been released on npm

mrkpatchaa · 2023-10-16T16:33:41Z

I will then remove @mrkpatchaa/phosphor-react-native from npm.
Thanks.

mrkpatchaa added 6 commits July 31, 2023 12:49

feat: generate icons from phospor/core

8e3cfea

feat: generate icons from phospor core

09aa89b

Remove svg files from repo

chore: bump version + upgrade dependencies

0f80715

build: upgrade husky version

6fb6fb3

build: upgrade example app to latest expo version

29f3e92

build: update regex to replace import type line in generated components

755ac98

This was referenced Aug 1, 2023

Update to last release v2.0.0 #27

Closed

Add a classname to an icon #26

Closed

mrkpatchaa added 3 commits August 5, 2023 18:08

fix: fix duplicate fill attribute on generated svg

8fbe2a4

fix: bob build

2ca1e23

fix: fix react-native-bob build

cc6f494

jacesimons14 approved these changes Aug 8, 2023

View reviewed changes

mrkpatchaa added 2 commits August 10, 2023 12:05

fix: bob build all src

233fa25

fix: types index file

06d54ad

fix: add react-native-svg

7d3e534

mrkpatchaa requested a review from jacesimons14 August 10, 2023 11:50

jacesimons14 approved these changes Aug 11, 2023

View reviewed changes

fix: add instructions for tsc errors

b418a98

Revert "feat: generate icons from phospor core"

d6995e0

This reverts commit 09aa89b.

mrkpatchaa mentioned this pull request Sep 10, 2023

chore: cleanup svg files from repo #35

Merged

jhhayashi approved these changes Sep 12, 2023

View reviewed changes

fix: pr comments

866eb6a

duongdev approved these changes Oct 5, 2023

View reviewed changes

duongdev merged commit cefe427 into duongdev:main Oct 5, 2023
1 check passed

mrkpatchaa mentioned this pull request Jun 20, 2024

New Icons #51

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade deps to 2.0 and Generate icons from @phosphor/core #33

Upgrade deps to 2.0 and Generate icons from @phosphor/core #33

mrkpatchaa commented Jul 31, 2023 •

edited

Loading

mrkpatchaa commented Aug 1, 2023

jacesimons14 commented Aug 8, 2023

mrkpatchaa commented Aug 8, 2023

jacesimons14 commented Aug 10, 2023

jacesimons14 commented Aug 10, 2023

mrkpatchaa commented Aug 10, 2023

mrkpatchaa commented Aug 10, 2023

jacesimons14 commented Aug 11, 2023

jacesimons14 commented Aug 11, 2023

mrkpatchaa commented Aug 11, 2023

jacesimons14 commented Aug 12, 2023

daxaxelrod commented Aug 22, 2023 •

edited

Loading

jhhayashi commented Sep 6, 2023

mrkpatchaa commented Sep 10, 2023

mrkpatchaa commented Sep 10, 2023

mrkpatchaa commented Sep 10, 2023

mrkpatchaa commented Sep 12, 2023

jhhayashi left a comment

jhhayashi Sep 12, 2023

mrkpatchaa Sep 13, 2023

jhhayashi Sep 12, 2023

mrkpatchaa Sep 13, 2023

jhhayashi Sep 12, 2023

jhhayashi Sep 12, 2023

mrkpatchaa commented Sep 13, 2023

DavidP-B commented Oct 4, 2023

mrkpatchaa commented Oct 4, 2023

duongdev commented Oct 5, 2023

mrkpatchaa commented Oct 5, 2023

jhhayashi commented Oct 5, 2023

mrkpatchaa commented Oct 5, 2023

jhhayashi commented Oct 15, 2023

mrkpatchaa commented Oct 16, 2023

	`${Case.capital(weight)}/${iconName}.svg`
	`${Case.pascal(weight)}/${iconName}.svg`

Upgrade deps to 2.0 and Generate icons from @phosphor/core #33

Upgrade deps to 2.0 and Generate icons from @phosphor/core #33

Conversation

mrkpatchaa commented Jul 31, 2023 • edited Loading

mrkpatchaa commented Aug 1, 2023

jacesimons14 commented Aug 8, 2023

mrkpatchaa commented Aug 8, 2023

jacesimons14 commented Aug 10, 2023

jacesimons14 commented Aug 10, 2023

mrkpatchaa commented Aug 10, 2023

mrkpatchaa commented Aug 10, 2023

jacesimons14 commented Aug 11, 2023

jacesimons14 commented Aug 11, 2023

mrkpatchaa commented Aug 11, 2023

jacesimons14 commented Aug 12, 2023

daxaxelrod commented Aug 22, 2023 • edited Loading

jhhayashi commented Sep 6, 2023

mrkpatchaa commented Sep 10, 2023

mrkpatchaa commented Sep 10, 2023

mrkpatchaa commented Sep 10, 2023

mrkpatchaa commented Sep 12, 2023

jhhayashi left a comment

Choose a reason for hiding this comment

jhhayashi Sep 12, 2023

Choose a reason for hiding this comment

mrkpatchaa Sep 13, 2023

Choose a reason for hiding this comment

jhhayashi Sep 12, 2023

Choose a reason for hiding this comment

mrkpatchaa Sep 13, 2023

Choose a reason for hiding this comment

jhhayashi Sep 12, 2023

Choose a reason for hiding this comment

jhhayashi Sep 12, 2023

Choose a reason for hiding this comment

mrkpatchaa commented Sep 13, 2023

DavidP-B commented Oct 4, 2023

mrkpatchaa commented Oct 4, 2023

duongdev commented Oct 5, 2023

mrkpatchaa commented Oct 5, 2023

jhhayashi commented Oct 5, 2023

mrkpatchaa commented Oct 5, 2023

jhhayashi commented Oct 15, 2023

mrkpatchaa commented Oct 16, 2023

mrkpatchaa commented Jul 31, 2023 •

edited

Loading

daxaxelrod commented Aug 22, 2023 •

edited

Loading