-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help with maintenance? #34
Comments
Hi @jhhayashi, thank for your willingness to help maintaining this repo. Very appreciated 🙇 I will add you as maintainer for this repo. Please also give me your npmjs user ID, I will add you as npm package maintainer too. Thanks! |
Sounds great. I have an active project that depends on this project, so I'm excited to help. My npmjs user ID is |
I got both invites and should be all set up 🚀 |
Cool. Could you please help release the latest changes to npm? Thank you! 🎉 |
Yep, will do! |
@duongdev are you able to approve my open PRs and/or grant me push access to the repo? I won't be able to do a tag push after an npm release |
@jhhayashi As this repo belongs to my personal Github account, I can only add you as collaborator. Because we have a protected branch rule on |
Got it. The one issue there is that if we use PRs to update the package.json version after a release, the commit hash will change when merging and the tag will be referencing the commit on the PR rather than the commit that lands in the main branch. Can you also enable force pushes for that case? |
@jhhayashi I have disabled "Require a pull request before merging" and enabled "Allow force pushes" to your github username. Could you try again? |
Force pushing to main still fails with a couple errors:
But I am able to create PRs and merge them. The downside is that |
Hey Dustin, thanks for all of the work putting together this library.
This library is linked to from the phosphor icon README, so it would be helpful to better understand your willingness to maintain and host it.
If you'd like to keep hosting the repo, but are looking for help maintaining it, I'd be happy to help. If you're no longer interested in hosting the repo, I'd also volunteer to take it (and the npm releases) over.
The text was updated successfully, but these errors were encountered: