fix(coverage): do not generate script coverage with empty url (denola…

…nd#24007) closes denoland#24004
dsherret · May 28, 2024 · 8b5089e · 8b5089e
1 parent 9aa593c
commit 8b5089e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/cli/tools/coverage/mod.rs b/cli/tools/coverage/mod.rs
@@ -68,12 +68,14 @@ impl crate::worker::CoverageCollector for CoverageCollector {
 
  let script_coverages = self.take_precise_coverage().await?.result;
  for script_coverage in script_coverages {
- // Filter out internal and http/https JS files from being included in coverage reports
+ // Filter out internal and http/https JS files and eval'd scripts
+ // from being included in coverage reports
  if script_coverage.url.starts_with("ext:")
  || script_coverage.url.starts_with("[ext:")
  || script_coverage.url.starts_with("http:")
  || script_coverage.url.starts_with("https:")
  || script_coverage.url.starts_with("node:")
+ || script_coverage.url.is_empty()
  {
  continue;
  }

diff --git a/tests/testdata/coverage/multisource/test.ts b/tests/testdata/coverage/multisource/test.ts
@@ -20,3 +20,7 @@ Deno.test("qux", () => {
 Deno.test("quux", () => {
  quux(false);
 });
+
+// Function constructor or eval function generates a new script source internally.
+// This call ensures that the coverage data for the eval script source is not generated.
+eval("console.log(1)");