Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coverage): do not generate script coverage with empty url #24007

Merged
merged 5 commits into from
May 28, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented May 28, 2024

closes #24004

This PR skips saving script_coverage as json when script_coverage.url is an empty string. This happens (strangely) when the test case includes Deno.statSync call (See #24004 for details).

@kt3k kt3k requested a review from bartlomieju May 28, 2024 10:06
@bartlomieju
Copy link
Member

You get empty URL because the struct used in statSync is code generated:

function createByteStruct(types) {

@kt3k
Copy link
Member Author

kt3k commented May 28, 2024

You get empty URL because the struct used in statSync is code generated:

Thanks! That explains it!

@kt3k kt3k merged commit 8b5089e into denoland:main May 28, 2024
17 checks passed
@kt3k kt3k deleted the skip-empty-url-coverage-file branch May 28, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coverage raw data with empty url is created when the test case include Deno.statSync call
3 participants