Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docs-ui): refactor to RenderUnit #2539

Open
wants to merge 22 commits into
base: dev
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: fix error emitted
  • Loading branch information
wzhudev committed Jun 17, 2024
commit a687e84d276a63d1662391cfe48f406000d2c94e
10 changes: 8 additions & 2 deletions packages/docs-ui/src/docs-ui-plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,12 @@ export class UniverDocsUIPlugin extends Plugin {
this._initializeCommands();
}

override onReady(): void {
this._initRenderBasics();
}

override onRendered(): void {
this._initModules();
this._initUI();
this._markDocAsFocused();
}

Expand Down Expand Up @@ -152,9 +156,11 @@ export class UniverDocsUIPlugin extends Plugin {
}
}

private _initModules(): void {
private _initUI(): void {
this._injector.get(AppUIController);
}

private _initRenderBasics(): void {
([
DocRenderController,
]).forEach((m) => {
Expand Down