Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docs-ui): refactor to RenderUnit #2539

Open
wants to merge 21 commits into
base: dev
Choose a base branch
from

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jun 17, 2024

Ref https://github.com/dream-num/univer-pro/issues/625.

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wzhudev wzhudev changed the title refactor: rename basic files refactor(docs-ui): refactor to RenderUnit Jun 17, 2024
Copy link

github-actions bot commented Jun 17, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev force-pushed the wzhudev/refactor/doc-render-unit branch from 479d84f to 5127019 Compare June 18, 2024 02:46
@wzhudev wzhudev force-pushed the wzhudev/refactor/doc-render-unit branch from 068245e to ff8f0ca Compare June 18, 2024 05:28
@wzhudev wzhudev force-pushed the wzhudev/refactor/doc-render-unit branch from ff8f0ca to e0fda40 Compare June 18, 2024 05:40
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 6.02911% with 904 lines in your changes missing coverage. Please review.

Project coverage is 27.21%. Comparing base (54edf21) to head (61fc0dc).

Files Patch % Lines
...lers/render-controllers/sheet.render-controller.ts 0.00% 204 Missing ⚠️
...rc/controllers/editor/editing.render-controller.ts 20.92% 189 Missing ⚠️
...ollers/render-controllers/doc.render-controller.ts 0.00% 112 Missing ⚠️
...llers/render-controllers/zoom.render-controller.ts 0.00% 100 Missing ⚠️
...er-controllers/text-selection.render-controller.ts 0.00% 83 Missing ⚠️
.../docs/src/services/doc-skeleton-manager.service.ts 2.85% 34 Missing ⚠️
...ontrollers/doc-drawing-update.render-controller.ts 0.00% 26 Missing ⚠️
...ckages/docs-ui/src/services/docs-render.service.ts 0.00% 25 Missing ⚠️
packages/docs-ui/src/docs-ui-plugin.ts 0.00% 18 Missing ⚠️
...kages/docs/src/commands/commands/delete.command.ts 0.00% 14 Missing ⚠️
... and 26 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2539      +/-   ##
==========================================
+ Coverage   27.18%   27.21%   +0.03%     
==========================================
  Files        1653     1651       -2     
  Lines       83623    83362     -261     
  Branches    17400    17360      -40     
==========================================
- Hits        22729    22688      -41     
+ Misses      60894    60674     -220     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev marked this pull request as ready for review June 18, 2024 09:13
@wzhudev wzhudev marked this pull request as draft June 18, 2024 09:42
@wzhudev wzhudev force-pushed the wzhudev/refactor/doc-render-unit branch from 92f1e89 to d0b8c91 Compare June 18, 2024 09:56
@wzhudev wzhudev force-pushed the wzhudev/refactor/doc-render-unit branch from d0b8c91 to 2d44a24 Compare June 18, 2024 10:15
@wzhudev wzhudev marked this pull request as ready for review June 18, 2024 12:00
@DR-Univer
Copy link
Collaborator

双击无法编辑

@univer-bot
Copy link

univer-bot bot commented Jun 18, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Unable to edit by double clicking

@@ -1,240 +0,0 @@
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drawing 的修改,可能会和我现在的 PR 冲突,我的PR好像也删除了这个文件

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants