ci: should throw no error on disposing unit

e2e/disposing/disposing.spec.ts

@@ -43,10 +43,27 @@ test('no error on constructing and disposing', async ({ page }) => {
  await page.waitForTimeout(2000);
 
  await page.evaluate(() => window.E2EControllerAPI.loadDefaultSheet());
- await page.waitForTimeout(2000); // wait for long enough to let the GC do its job
+ await page.waitForTimeout(2000);
 
  await page.evaluate(() => window.E2EControllerAPI.disposeUniver());
- await page.waitForTimeout(2000); // wait for long enough to let the GC do its job
+ await page.waitForTimeout(2000);
+
+ expect(errored).toBeFalsy();
+});
+
+test('no error when dispose a unit', async ({ page }) => {
+ let errored = false;
+
+ page.on('pageerror', (error) => {
+ console.error('Page error:', error);
+ errored = true;
+ });
+
+ await page.goto('http:https://localhost:3000/sheets/');
+ await page.waitForTimeout(2000);
+
+ await page.evaluate(() => window.E2EControllerAPI.loadAndRelease(1));
+ await page.waitForTimeout(2000);
 
  expect(errored).toBeFalsy();
 });

e2e/memory/memory.spec.ts

@@ -23,6 +23,7 @@ import { expect, test } from '@playwright/test';
 // examples/src/plugins/debugger/controllers/e2e/e2e-memory.controller.ts
 export interface IE2EControllerAPI {
  loadAndRelease(id: number): Promise<void>;
+ loadDefaultSheet(): Promise<void>;
  disposeUniver(): Promise<void>;
 }
 

packages/sheets-thread-comment/src/types/const.ts

@@ -16,4 +16,4 @@
 
 export const SHEETS_THREAD_COMMENT_MODAL = 'univer.sheet.thread-comment-modal';
 export const COMMENT_SINGLE_ICON = 'comment-single';
-export const SHEETS_THREAD_COMMENT = 'univer.sheet.thread-comment';
+export const SHEETS_THREAD_COMMENT = 'SHEET_THREAD_COMMENT';