Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disposing unit should not emit error #2529

Merged
merged 13 commits into from
Jun 15, 2024
Merged

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jun 15, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 12.79762% with 293 lines in your changes missing coverage. Please review.

Project coverage is 27.17%. Comparing base (85e15af) to head (3a50452).

Files Patch % Lines
...ts-ui/src/controllers/menu/permission-menu-util.ts 0.00% 228 Missing ⚠️
...ckages/sheets-ui/src/controllers/menu/menu-util.ts 51.61% 30 Missing ⚠️
packages/sheets-formula/src/controllers/menu.ts 0.00% 10 Missing ⚠️
...workbook-permission/workbook-permission.service.ts 16.66% 10 Missing ⚠️
...ges/core/src/services/instance/instance.service.ts 46.15% 7 Missing ⚠️
.../services/mark-selection/mark-selection.service.ts 0.00% 4 Missing ⚠️
...rksheet-permission/worksheet-permission.service.ts 50.00% 3 Missing ⚠️
packages/sheets-thread-comment/src/types/const.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2529      +/-   ##
==========================================
+ Coverage   27.16%   27.17%   +0.01%     
==========================================
  Files        1654     1653       -1     
  Lines       83476    83494      +18     
  Branches    17356    17363       +7     
==========================================
+ Hits        22674    22692      +18     
  Misses      60802    60802              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 15, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@ybzky ybzky requested a review from jikkai as a code owner June 15, 2024 03:56
@ybzky ybzky requested a review from Dushusir as a code owner June 15, 2024 06:12
@ybzky ybzky force-pushed the wzhudev/fix/dispose-unit-ci branch from c53ca5c to f9a6163 Compare June 15, 2024 07:53
@ybzky ybzky requested a review from hexf00 as a code owner June 15, 2024 08:07
@wzhudev wzhudev merged commit 2c44815 into dev Jun 15, 2024
9 checks passed
@wzhudev wzhudev deleted the wzhudev/fix/dispose-unit-ci branch June 15, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants