Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): fix ineffective hidden property in menu configurations #2420

Merged
merged 1 commit into from
Jun 5, 2024
Merged

fix(ui): fix ineffective hidden property in menu configurations #2420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(ui): fix ineffective hidden property in menu configurations
  • Loading branch information
@jikkai
jikkai committed Jun 5, 2024
commit b74f3a602d63f73a2acada79efaed8486cc8913b
4 changes: 2 additions & 2 deletions packages/ui/src/common/menu-merge-configs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ export function mergeMenuConfigs<T = MenuConfig>(baseConfig: T, additionalConfig
});

// Update reactive properties
const observableProperties = ['hidden$', 'disabled$', 'activated$'];
const observableProperties = ['hidden', 'disabled', 'activated'];
observableProperties.forEach((prop) => {
updateReactiveProperty(baseConfig, prop as keyof typeof baseConfig, (additionalConfig as any)[prop]);
updateReactiveProperty(baseConfig, `${prop}$` as keyof typeof baseConfig, (additionalConfig as any)[prop]);
});

return baseConfig;
Expand Down
Loading