Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fix ineffective hidden property in menu configurations #2420

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Jun 5, 2024

close #2419

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@jikkai jikkai requested a review from Jocs as a code owner June 5, 2024 01:45
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.09%. Comparing base (c21a213) to head (b74f3a6).

Files Patch % Lines
packages/ui/src/common/menu-merge-configs.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2420   +/-   ##
=======================================
  Coverage   27.09%   27.09%           
=======================================
  Files        1646     1646           
  Lines       83110    83110           
  Branches    17221    17221           
=======================================
  Hits        22521    22521           
  Misses      60589    60589           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 5, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@jikkai jikkai removed the qa:untested This PR is ready to be tested label Jun 5, 2024
@jikkai jikkai merged commit c2b0019 into dev Jun 5, 2024
9 checks passed
@jikkai jikkai deleted the fix/menu-hidden branch June 5, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Failing To Hide Menu Items
1 participant