Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "chore(typescript): migrate ts from 5.3 to 5.4 with accompanying code adjustments" #1546

Closed
wants to merge 1 commit into from

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Mar 11, 2024

Reverts #1540

Due to the incomplete support of TypeScript 5.4.2 in NestJS used in the pro version, temporarily revert this PR.

@jikkai jikkai changed the title Revert "chore(typescript): migrate ts from 5.3 to 5.4 with accompanying code adjustments" revert: "chore(typescript): migrate ts from 5.3 to 5.4 with accompanying code adjustments" Mar 11, 2024
Copy link

View Deployment

#8232681742

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 32.91%. Comparing base (351e2a4) to head (e4b0340).

Files Patch % Lines
packages/ui/src/services/shortcut/keycode.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1546      +/-   ##
==========================================
+ Coverage   32.90%   32.91%   +0.01%     
==========================================
  Files         919      919              
  Lines       51149    51129      -20     
  Branches    10645    10645              
==========================================
  Hits        16829    16829              
+ Misses      34320    34300      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai marked this pull request as draft March 11, 2024 12:24
@jikkai jikkai closed this Mar 11, 2024
@jikkai jikkai deleted the revert-1540-chore/typescript-5.4 branch March 15, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant