Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(typescript): migrate ts from 5.3 to 5.4 with accompanying code adjustments #1540

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Mar 11, 2024

  • I am sure that the code is update-to-date with the dev branch.

Copy link

github-actions bot commented Mar 11, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 32.90%. Comparing base (ef48825) to head (67b5257).

Files Patch % Lines
packages/engine-render/src/context.ts 0.00% 20 Missing ⚠️
packages/ui/src/services/shortcut/keycode.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1540      +/-   ##
==========================================
- Coverage   32.91%   32.90%   -0.02%     
==========================================
  Files         919      919              
  Lines       51126    51146      +20     
  Branches    10644    10644              
==========================================
  Hits        16829    16829              
- Misses      34297    34317      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai merged commit 565bd5a into dev Mar 11, 2024
7 checks passed
@jikkai jikkai deleted the chore/typescript-5.4 branch March 11, 2024 10:42
jikkai added a commit that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant