Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheet-ui): find & replace #1349

Merged
merged 17 commits into from
Mar 15, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: do not update findCompleted on content change
  • Loading branch information
wzhudev committed Mar 14, 2024
commit 129aa0f1de2a1ae1e86955a9d4fe6fb6c098100b
4 changes: 2 additions & 2 deletions packages/find-replace/src/services/find-replace.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -317,10 +317,10 @@ export class FindReplaceModel extends Disposable {
const newMatches = this._matches = allMatches.flat();
if (newMatches.length) {
const index = this._moveToInitialMatch(this._findModels, newMatches, true);
this._state.changeState({ matchesCount: newMatches.length, matchesPosition: index + 1, findCompleted: false });
this._state.changeState({ matchesCount: newMatches.length, matchesPosition: index + 1 });
this.replaceables$.next(newMatches.filter((m) => m.replaceable) as IReplaceableMatch[]);
} else {
this._state.changeState({ matchesCount: 0, matchesPosition: 0, findCompleted: false });
this._state.changeState({ matchesCount: 0, matchesPosition: 0 });
this.replaceables$.next([]);
}
});
Expand Down