Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheet-ui): find & replace #1349

Merged
merged 17 commits into from
Mar 15, 2024
Merged

feat(sheet-ui): find & replace #1349

merged 17 commits into from
Mar 15, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Feb 7, 2024

  • I am sure that the code is update-to-date with the dev branch.

close https://github.com/dream-num/univer-pro/issues/242
close #1239

Copy link

github-actions bot commented Feb 8, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev force-pushed the wzhudev/feat-find-replace branch 7 times, most recently from bbe78be to fa225ea Compare February 26, 2024 09:39
@wzhudev wzhudev force-pushed the wzhudev/feat-find-replace branch 9 times, most recently from 0ffa2a2 to 5019943 Compare March 8, 2024 04:29
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 4.95988% with 1303 lines in your changes are missing coverage. Please review.

Project coverage is 32.37%. Comparing base (5c99f3a) to head (3f2cd6f).
Report is 5 commits behind head on dev.

Files Patch % Lines
...e/src/controllers/sheet-find-replace.controller.ts 6.61% 494 Missing ⚠️
.../find-replace/src/services/find-replace.service.ts 0.00% 308 Missing ⚠️
...ind-replace/src/views/dialog/FindReplaceDialog.tsx 0.00% 118 Missing ⚠️
...ges/sheets-ui/src/controllers/scroll.controller.ts 0.00% 83 Missing ⚠️
...ges/core/src/services/undoredo/undoredo.service.ts 7.31% 38 Missing ⚠️
...replace/src/controllers/find-replace.controller.ts 0.00% 25 Missing ⚠️
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 24 Missing ⚠️
...nd-replace/src/commands/command/replace.command.ts 0.00% 23 Missing ⚠️
...ages/find-replace/src/views/dialog/SearchInput.tsx 0.00% 19 Missing ⚠️
...d-replace/src/controllers/find-replace.shortcut.ts 0.00% 18 Missing ⚠️
... and 30 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1349      +/-   ##
==========================================
- Coverage   32.80%   32.37%   -0.44%     
==========================================
  Files         919      923       +4     
  Lines       51298    52105     +807     
  Branches    10694    10873     +179     
==========================================
+ Hits        16830    16867      +37     
- Misses      34468    35238     +770     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev force-pushed the wzhudev/feat-find-replace branch 2 times, most recently from 02f8fd8 to 4cdd26c Compare March 8, 2024 05:11
@wzhudev wzhudev marked this pull request as ready for review March 8, 2024 05:11
@wzhudev wzhudev added the qa:untested This PR is ready to be tested label Mar 8, 2024
@wzhudev wzhudev force-pushed the wzhudev/feat-find-replace branch 3 times, most recently from 98c1ba2 to 84d2853 Compare March 11, 2024 08:25
@wzhudev wzhudev force-pushed the wzhudev/feat-find-replace branch 3 times, most recently from 9d9e045 to b9b30ab Compare March 15, 2024 05:52
@wzhudev wzhudev changed the title feat(sheet-ui): add find & replace feature feat(sheet-ui): find & replace Mar 15, 2024
@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Mar 15, 2024
@wzhudev wzhudev merged commit 3828239 into dev Mar 15, 2024
7 checks passed
@wzhudev wzhudev deleted the wzhudev/feat-find-replace branch March 15, 2024 06:27
ybzky pushed a commit that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
3 participants