Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support overriding virtual indexer property in proxies #22258

Merged
merged 3 commits into from
Aug 28, 2020
Merged

Support overriding virtual indexer property in proxies #22258

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3dd4c3c
Support overriding virtual indexer property in proxies
ajcvickers Aug 26, 2020
5b398ce
Treat indexer properties like nullable backing fields when handling d…
ajcvickers Aug 27, 2020
59f0f2c
Cleanup
ajcvickers Aug 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Cleanup
  • Loading branch information
@ajcvickers
ajcvickers committed Aug 27, 2020
commit 59f0f2c241502465bed42fc0c78105b355d69d9b
6 changes: 3 additions & 3 deletions src/EFCore/ChangeTracking/Internal/SnapshotFactoryFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,9 @@ protected virtual Expression CreateSnapshotExpression(
var hasDefaultValueExpression = memberAccess.MakeHasDefaultValue(propertyBase);

memberAccess = Expression.Condition(
hasDefaultValueExpression,
propertyBase.ClrType.GetDefaultValueConstant(),
Expression.Convert(memberAccess, propertyBase.ClrType));
hasDefaultValueExpression,
propertyBase.ClrType.GetDefaultValueConstant(),
Expression.Convert(memberAccess, propertyBase.ClrType));
}

arguments[i] = (propertyBase as INavigation)?.IsCollection ?? false
Expand Down