Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support overriding virtual indexer property in proxies #22258

Merged
merged 3 commits into from
Aug 28, 2020

Conversation

ajcvickers
Copy link
Member

Fixes #21985

@ajcvickers ajcvickers requested a review from a team August 26, 2020 22:12
@ajcvickers
Copy link
Member Author

@Pilchie RC1

@smitpatel
Copy link
Member

May be should also remove line from #21948 (comment)

@ajcvickers
Copy link
Member Author

@smitpatel Dictionary is not proxyable. We might want to throw if people try to use it as a proxy type, but that would also fail all our current tests. We should discuss in the context of #22009.

@Pilchie
Copy link
Member

Pilchie commented Aug 26, 2020

Approved for RC1.

@ajcvickers
Copy link
Member Author

@smitpatel @AndriySvyryd Added another commit which improves this significantly by handling null values returned from indexer properties in the same way we handle null values in the backing field of a non-nullable property.

@ajcvickers ajcvickers merged commit 7c9d5fb into release/5.0 Aug 28, 2020
@ajcvickers ajcvickers deleted the BlackHole0825 branch August 28, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change-tracking proxies don't detect changes in Indexer properties
4 participants