Fixed some of the examples in PyHSPF/examples/gis directory. Implemented new NHDPlusExtractor. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djlampert
approved these changes
Jul 18, 2018
There was a problem hiding this comment.
climateprocessor08.py—lines 168-181 and 225-230. Why are all these commented out?
Ftable01.py—why is the json import statement here?
ftable02.py—why change the gage station number?
huc08example.py—line 45. Why is the print statement here?
Climateprocessor.py—line 249-256. Why the indentation?
Gagestation.py—lines 263-283. Probably should add some error handling to provide specific language if the try statement fails. If the server changes, the message should provide info to help illustrate this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Implemented new NHDPlusExtractor Class
-Fixed issues with ftable, and cdl examples
-Added link.txt file to prerequisite data folder
-Modified nwisextractor, and cdlextractor to accommodate changes in nwis and cdl websites