Skip to content

Commit

Permalink
[testbed] Remove unused AWS X-Ray mock receiver (open-telemetry#30381)
Browse files Browse the repository at this point in the history
The test using this mock receiver was disabled more than 3 years ago
open-telemetry#1387
and never restored after that.

Proposing to remove the dead code to reduce the maintenance overhead.

Pinging code owner @wangzlei, @srprash. Let us know if it's ok to remove
if you want to revive the test instead.
  • Loading branch information
dmitryax committed Jan 11, 2024
1 parent b59acdd commit e8c85ec
Show file tree
Hide file tree
Showing 22 changed files with 22 additions and 651 deletions.
22 changes: 22 additions & 0 deletions .chloggen/breaking-remove-unused-AwsXray-tesbed-mock-receiver.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: testbed

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Remove unused AWS XRay mock receiver

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [30381]

# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: [api]
1 change: 0 additions & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,6 @@ receiver/zipkinreceiver/ @open-telemetry/collect
receiver/zookeeperreceiver/ @open-telemetry/collector-contrib-approvers @djaglowski

testbed/ @open-telemetry/collector-contrib-approvers @open-telemetry/collector-approvers
testbed/mockdatareceivers/mockawsxrayreceiver/ @open-telemetry/collector-contrib-approvers @wangzlei @srprash
testbed/mockdatasenders/mockdatadogagentexporter/ @open-telemetry/collector-contrib-approvers @boostchicken

#####################################################
Expand Down
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/bug_report.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,6 @@ body:
- receiver/zipkin
- receiver/zookeeper
- testbed
- testbed/mockdatareceivers/mockawsxrayreceiver
- testbed/mockdatasenders/mockdatadogagentexporter
# End Collector components list
- type: textarea
Expand Down
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/feature_request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,6 @@ body:
- receiver/zipkin
- receiver/zookeeper
- testbed
- testbed/mockdatareceivers/mockawsxrayreceiver
- testbed/mockdatasenders/mockdatadogagentexporter
# End Collector components list
- type: textarea
Expand Down
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/other.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,6 @@ body:
- receiver/zipkin
- receiver/zookeeper
- testbed
- testbed/mockdatareceivers/mockawsxrayreceiver
- testbed/mockdatasenders/mockdatadogagentexporter
# End Collector components list
- type: textarea
Expand Down
2 changes: 0 additions & 2 deletions cmd/configschema/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -1157,8 +1157,6 @@ replace (

replace github.com/open-telemetry/opentelemetry-collector-contrib/testbed/mockdatasenders/mockdatadogagentexporter => ../../testbed/mockdatasenders/mockdatadogagentexporter

replace github.com/open-telemetry/opentelemetry-collector-contrib/testbed/mockdatareceivers/mockawsxrayreceiver => ../../testbed/mockdatareceivers/mockawsxrayreceiver

replace github.com/open-telemetry/opentelemetry-collector-contrib/testbed => ../../testbed

replace github.com/open-telemetry/opentelemetry-collector-contrib/exporter/syslogexporter => ../../exporter/syslogexporter
1 change: 0 additions & 1 deletion cmd/otelcontribcol/builder-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -448,4 +448,3 @@ replaces:
- github.com/open-telemetry/opentelemetry-collector-contrib/extension/opampextension => ../../extension/opampextension
- github.com/open-telemetry/opentelemetry-collector-contrib/testbed/mockdatasenders/mockdatadogagentexporter => ../../testbed/mockdatasenders/mockdatadogagentexporter
- github.com/open-telemetry/opentelemetry-collector-contrib/testbed => ../../testbed
- github.com/open-telemetry/opentelemetry-collector-contrib/testbed/mockdatareceivers/mockawsxrayreceiver => ../../testbed/mockdatareceivers/mockawsxrayreceiver
2 changes: 0 additions & 2 deletions cmd/otelcontribcol/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -1189,5 +1189,3 @@ replace github.com/open-telemetry/opentelemetry-collector-contrib/extension/opam
replace github.com/open-telemetry/opentelemetry-collector-contrib/testbed/mockdatasenders/mockdatadogagentexporter => ../../testbed/mockdatasenders/mockdatadogagentexporter

replace github.com/open-telemetry/opentelemetry-collector-contrib/testbed => ../../testbed

replace github.com/open-telemetry/opentelemetry-collector-contrib/testbed/mockdatareceivers/mockawsxrayreceiver => ../../testbed/mockdatareceivers/mockawsxrayreceiver
2 changes: 0 additions & 2 deletions extension/healthcheckextension/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,6 @@ replace github.com/open-telemetry/opentelemetry-collector-contrib/pkg/pdatautil

replace github.com/open-telemetry/opentelemetry-collector-contrib/exporter/syslogexporter => ../../exporter/syslogexporter

replace github.com/open-telemetry/opentelemetry-collector-contrib/testbed/mockdatareceivers/mockawsxrayreceiver => ../../testbed/mockdatareceivers/mockawsxrayreceiver

replace github.com/open-telemetry/opentelemetry-collector-contrib/exporter/zipkinexporter => ../../exporter/zipkinexporter

replace github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver => ../../receiver/prometheusreceiver
Expand Down
2 changes: 0 additions & 2 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -1157,8 +1157,6 @@ replace (
github.com/open-telemetry/opentelemetry-collector-contrib/connector/spanmetricsconnector => ./connector/spanmetricsconnector
)

replace github.com/open-telemetry/opentelemetry-collector-contrib/testbed/mockdatareceivers/mockawsxrayreceiver => ./testbed/mockdatareceivers/mockawsxrayreceiver

replace github.com/open-telemetry/opentelemetry-collector-contrib/testbed/mockdatasenders/mockdatadogagentexporter => ./testbed/mockdatasenders/mockdatadogagentexporter

replace github.com/open-telemetry/opentelemetry-collector-contrib/testbed => ./testbed
Expand Down
87 changes: 0 additions & 87 deletions testbed/datareceivers/mockawsxraydatareceiver.go

This file was deleted.

3 changes: 0 additions & 3 deletions testbed/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ require (
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/splunkhecreceiver v0.92.0
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/syslogreceiver v0.92.0
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/zipkinreceiver v0.92.0
github.com/open-telemetry/opentelemetry-collector-contrib/testbed/mockdatareceivers/mockawsxrayreceiver v0.92.0
github.com/open-telemetry/opentelemetry-collector-contrib/testbed/mockdatasenders/mockdatadogagentexporter v0.92.0
github.com/prometheus/common v0.45.0
github.com/prometheus/prometheus v0.48.1
Expand Down Expand Up @@ -334,8 +333,6 @@ replace github.com/open-telemetry/opentelemetry-collector-contrib/receiver/syslo

replace github.com/open-telemetry/opentelemetry-collector-contrib/receiver/zipkinreceiver => ../receiver/zipkinreceiver

replace github.com/open-telemetry/opentelemetry-collector-contrib/testbed/mockdatareceivers/mockawsxrayreceiver => ../testbed/mockdatareceivers/mockawsxrayreceiver

replace github.com/open-telemetry/opentelemetry-collector-contrib/testbed/mockdatasenders/mockdatadogagentexporter => ../testbed/mockdatasenders/mockdatadogagentexporter

replace github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/jaeger => ../pkg/translator/jaeger
Expand Down
1 change: 0 additions & 1 deletion testbed/mockdatareceivers/mockawsxrayreceiver/Makefile

This file was deleted.

19 changes: 0 additions & 19 deletions testbed/mockdatareceivers/mockawsxrayreceiver/config.go

This file was deleted.

50 changes: 0 additions & 50 deletions testbed/mockdatareceivers/mockawsxrayreceiver/factory.go

This file was deleted.

51 changes: 0 additions & 51 deletions testbed/mockdatareceivers/mockawsxrayreceiver/go.mod

This file was deleted.

Loading

0 comments on commit e8c85ec

Please sign in to comment.